vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clean code (#35340)

Browse source 
* clean code

* clean code

* clean code
This commit is contained in:
Frédéric FRANCE 2025-09-14 11:57:52 +02:00 committed by GitHub
parent 62a7756a43
commit f14bc0bfbe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
dev/build/phpstan/phpstan-baseline.neon
View file

@ -7050,18 +7050,6 @@ parameters:
count: 1
path: ../../../htdocs/core/class/html.formsetup.class.php
-
message: '#^Loose comparison using \!\= between 1 and ''1'' will always evaluate to false\.$#'
identifier: notEqual.alwaysFalse
count: 1
path: ../../../htdocs/core/class/html.formsms.class.php
-
message: '#^Result of && is always false\.$#'
identifier: booleanAnd.alwaysFalse
count: 1
path: ../../../htdocs/core/class/html.formsms.class.php
-
message: '#^Call to function is_array\(\) with array will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType

8
htdocs/core/class/html.formsms.class.php
View file

@ -1,7 +1,7 @@
<?php
/* Copyright (C) 2005-2011 Laurent Destailleur <eldy@users.sourceforge.net>
* Copyright (C) 2010 Juanjo Menent <jmenent@2byte.es>
* Copyright (C) 2018-2024 Frédéric France <frederic.france@free.fr>
* Copyright (C) 2018-2025 Frédéric France <frederic.france@free.fr>
* Copyright (C) 2024 MDW <mdeweerd@users.noreply.github.com>
*
* This program is free software; you can redistribute it and/or modify
@ -21,7 +21,7 @@
/**
* \file htdocs/core/class/html.formsms.class.php
* \ingroup core
* \brief Fichier de la class permettant la generation du formulaire html d'envoi de mail unitaire
* \brief Class file for generating the HTML form used to send individual SMS messages
*/
require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';
@ -84,7 +84,7 @@ class FormSms
public $withfrom;
/**
* @var int<0,1>
* @var int<0,1>|string[]
*/
public $withto;
@ -315,7 +315,7 @@ function limitChars(textarea, limit, infodiv)
if ($this->withtoreadonly) {
print (!is_array($this->withto) && !is_numeric($this->withto)) ? $this->withto : "";
} else {
print '<input class="width150" id="sendto" name="sendto" value="'.dol_escape_htmltag(!is_array($this->withto) && $this->withto != '1' ? (GETPOSTISSET("sendto") ? GETPOST("sendto") : $this->withto) : "+").'">';
print '<input class="width150" id="sendto" name="sendto" value="'.dol_escape_htmltag(!is_array($this->withto) /* && $this->withto != '1' // always true */ ? (GETPOSTISSET("sendto") ? GETPOST("sendto") : $this->withto) : "+").'">';
if (!empty($this->withtosocid) && $this->withtosocid > 0) {
$liste = array();
foreach ($soc->thirdparty_and_contact_phone_array() as $key => $value) {