qual: phpstan for htdocs/fourn/class/fournisseur.commande.class.php

htdocs/fourn/class/fournisseur.commande.class.php	1146	Method CommandeFournisseur::getNextNumRef() should return string but returns int.
htdocs/fourn/class/fournisseur.commande.class.php	1150	Method CommandeFournisseur::getNextNumRef() should return string but returns int.
htdocs/fourn/class/fournisseur.commande.class.php	1867	Property CommandeFournisseur::$date_creation (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.class.php	1869	Property CommandeFournisseur::$ref_supplier (string) does not accept null.
htdocs/fourn/class/fournisseur.commande.class.php	1870	Property CommandeFournisseur::$user_approve_id (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.class.php	1871	Property CommandeFournisseur::$user_approve_id2 (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.class.php	1872	Property CommandeFournisseur::$date_approve (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.class.php	1873	Property CommandeFournisseur::$date_approve2 (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.class.php	3020	Property CommonOrderLine::$remise_percent (float) does not accept string.
htdocs/fourn/class/fournisseur.commande.class.php	3048	Property CommonOrderLine::$remise_percent (float) does not accept string.
This commit is contained in:
thibdrev 2024-01-28 17:35:17 +01:00 committed by GitHub
parent 92cf4f2fd1
commit f03f5b6be4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1104,11 +1104,11 @@ class CommandeFournisseur extends CommonOrder
/**
* Returns the following order reference not used depending on the numbering model activated
* defined within COMMANDE_SUPPLIER_ADDON_NUMBER
* Returns the next order reference not used, based on the
* numbering model defined within COMMANDE_SUPPLIER_ADDON_NUMBER
*
* @param Societe $soc company object
* @return string free reference for the invoice
* @return string|int free reference for the invoice
*/
public function getNextNumRef($soc)
{
@ -1864,13 +1864,13 @@ class CommandeFournisseur extends CommonOrder
// Clear fields
$this->user_author_id = $user->id;
$this->user_validation_id = 0;
$this->date_creation = '';
$this->date_validation = '';
$this->ref_supplier = null;
$this->user_approve_id = '';
$this->user_approve_id2 = '';
$this->date_approve = '';
$this->date_approve2 = '';
$this->date_creation = 0;
$this->date_validation = 0;
$this->ref_supplier = '';
$this->user_approve_id = 0;
$this->user_approve_id2 = 0;
$this->date_approve = 0;
$this->date_approve2 = 0;
// Create clone
$this->context['createfromclone'] = 'createfromclone';
@ -2923,7 +2923,7 @@ class CommandeFournisseur extends CommonOrder
$remise_percent = 0;
}
$remise_percent = price2num($remise_percent);
$remise_percent = (float) price2num($remise_percent);
$qty = price2num($qty);
if (!$qty) {
$qty = 1;