From d81c124b77f585cbf1c06365dd55a0ea2493f32e Mon Sep 17 00:00:00 2001 From: John BOTELLA <68917336+thersane-john@users.noreply.github.com> Date: Fri, 28 Feb 2025 11:55:32 +0100 Subject: [PATCH 01/32] Fix setup default value --- htdocs/core/class/html.formsetup.class.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/core/class/html.formsetup.class.php b/htdocs/core/class/html.formsetup.class.php index efc97ad63f2..392fa8232c1 100644 --- a/htdocs/core/class/html.formsetup.class.php +++ b/htdocs/core/class/html.formsetup.class.php @@ -700,10 +700,10 @@ class FormSetupItem { global $conf; if (isset($conf->global->{$this->confKey})) { - $this->fieldValue = getDolGlobalString($this->confKey); + $this->fieldValue = getDolGlobalString($this->confKey, null); return true; } else { - $this->fieldValue = ''; + $this->fieldValue = null; return false; } } From 1418bb9157a9fcc18ef4eda8583ce4abd58193b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?= Date: Sun, 2 Mar 2025 11:51:53 +0100 Subject: [PATCH 02/32] fix CI branch 21.0 --- htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php b/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php index f1469969582..e2af25918ee 100644 --- a/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php +++ b/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php @@ -794,9 +794,9 @@ class pdf_cornas extends ModelePDFSuppliersOrders // Show square if ($pagenb == $pageposbeforeprintlines) { - $this->_tableau($pdf, $tab_top, $this->page_hauteur - $tab_top - $heightforinfotot - $heightforfreetext - $heightforfooter, 0, $outputlangs, $hidetop, 0, $object->multicurrency_code, $outputlangsbis); + $this->_tableau($pdf, $tab_top, $this->page_hauteur - $tab_top - $heightforinfotot - $heightforfreetext - $heightforfooter, 0, $outputlangs, $hidetop, 0, $object->multicurrency_code); } else { - $this->_tableau($pdf, $tab_top_newpage, $this->page_hauteur - $tab_top_newpage - $heightforinfotot - $heightforfreetext - $heightforfooter, 0, $outputlangs, 1, 0, $object->multicurrency_code, $outputlangsbis); + $this->_tableau($pdf, $tab_top_newpage, $this->page_hauteur - $tab_top_newpage - $heightforinfotot - $heightforfreetext - $heightforfooter, 0, $outputlangs, 1, 0, $object->multicurrency_code); } $bottomlasttab = $this->page_hauteur - $heightforinfotot - $heightforfreetext - $heightforfooter + 1; From 1796050a6d45c34085106289b3fb6c4d01bed445 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?= Date: Sun, 2 Mar 2025 11:56:57 +0100 Subject: [PATCH 03/32] Update export_files.php --- htdocs/admin/tools/export_files.php | 1 + 1 file changed, 1 insertion(+) diff --git a/htdocs/admin/tools/export_files.php b/htdocs/admin/tools/export_files.php index bc52bcadc4a..6c9ed65f840 100644 --- a/htdocs/admin/tools/export_files.php +++ b/htdocs/admin/tools/export_files.php @@ -165,6 +165,7 @@ if ($compression == 'zip') { } } + global $errormsg; $ret = dol_compress_dir($fulldirtocompress, $outputdir."/".$file, $compression, $excludefiles, $rootdirinzip); if ($ret < 0) { if ($ret == -2) { From 6c632259291469a0d22609f1a81c62a1c5a9d8c1 Mon Sep 17 00:00:00 2001 From: Alexandre Janniaux Date: Sun, 2 Mar 2025 14:59:25 +0100 Subject: [PATCH 04/32] TraceableDB: add missing regexpsql() wrapper The TraceableDB must also redirect to the underlying database object for regexpsql queries, otherwise, a DoliDBPgsql DB with the debugbar enabled would try to use REGEXP() commands which are not supported on Postgresql. --- htdocs/debugbar/class/TraceableDB.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/htdocs/debugbar/class/TraceableDB.php b/htdocs/debugbar/class/TraceableDB.php index 9211e8e5fae..2d4a98c47a6 100644 --- a/htdocs/debugbar/class/TraceableDB.php +++ b/htdocs/debugbar/class/TraceableDB.php @@ -86,6 +86,19 @@ class TraceableDB extends DoliDB return $this->db->ifsql($test, $resok, $resko); } + /** + * format a sql regexp + * + * @param string $subject field name to test + * @param string $pattern sql pattern to match + * @param int $sqlstring 0=the string being tested is a hard coded string, 1=the string is a field + * @return string sql string + */ + public function regexpsql($subject, $pattern, $sqlstring = 0): string + { + return $this->db->regexpsql($subject, $pattern, $sqlstring = 0); + } + // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps /** * Return datas as an array From c2aa1fe7a6c30b9f95f477daf4ea709311d4d698 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Sun, 2 Mar 2025 18:44:04 +0100 Subject: [PATCH 05/32] Missing log for services --- htdocs/core/lib/website2.lib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/core/lib/website2.lib.php b/htdocs/core/lib/website2.lib.php index b0a6d59b935..a465e140ac1 100644 --- a/htdocs/core/lib/website2.lib.php +++ b/htdocs/core/lib/website2.lib.php @@ -183,7 +183,7 @@ function dolSavePageContent($filetpl, Website $object, WebsitePage $objectpage, $tplcontent .= "} // Not already loaded\n"; $tplcontent .= "require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';\n"; $tplcontent .= "require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';\n"; - if (in_array($objectpage->type_container, array('page', 'blogpost'))) { + if (in_array($objectpage->type_container, array('page', 'blogpost', 'service'))) { $tplcontent .= 'dol_syslog("--- Prepare content of page '.((int) $objectpage->id).' - '.$objectpage->pageurl.'");'."\n"; } $tplcontent .= "ob_start();\n"; @@ -373,7 +373,7 @@ function dolSavePageContent($filetpl, Website $object, WebsitePage $objectpage, $tplcontent .= "} // Not already loaded\n"; $tplcontent .= "require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';\n"; $tplcontent .= "require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';\n"; - if (in_array($objectpage->type_container, array('page', 'blogpost'))) { + if (in_array($objectpage->type_container, array('page', 'blogpost', 'service'))) { $tplcontent .= 'dol_syslog("--- Prepare content of page '.((int) $objectpage->id).' - '.$objectpage->pageurl.'");'."\n"; } $tplcontent .= "// END PHP ?>\n"; From 812d9ad05186d439689f900d8dfaf9c5184b148c Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Sun, 2 Mar 2025 19:13:06 +0100 Subject: [PATCH 06/32] Debug v12 - fix delay of cache --- htdocs/core/lib/website.lib.php | 2 +- htdocs/viewimage.php | 11 ++++------- htdocs/website/samples/wrapper.php | 4 +++- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/htdocs/core/lib/website.lib.php b/htdocs/core/lib/website.lib.php index c9844e27f17..bbc77d1a452 100644 --- a/htdocs/core/lib/website.lib.php +++ b/htdocs/core/lib/website.lib.php @@ -558,7 +558,7 @@ function redirectToContainer($containerref, $containeraliasalt = '', $containeri unset($tmpwebsitepage); } if ($result > 0) { - $currenturi = $_SERVER["REQUEST_URI"]; // Example: /public/website/index.php?website=mywebsite.com&pageref=mywebsite-home&nocache=1708177483 + $currenturi = $_SERVER["REQUEST_URI"]; // Example: /public/website/index.php?website=mywebsite.com&pageref=mywebsite-home&cache=3600 $regtmp = array(); if (preg_match('/&pageref=([^&]+)/', $currenturi, $regtmp)) { if ($regtmp[0] == $containerref) { diff --git a/htdocs/viewimage.php b/htdocs/viewimage.php index 1bbf7224a02..899fffa181b 100644 --- a/htdocs/viewimage.php +++ b/htdocs/viewimage.php @@ -189,20 +189,17 @@ if ($modulepart == 'fckeditor') { * View */ -if (GETPOST("cache", 'alpha')) { +$cachestring = GETPOST("cache", 'aZ09'); // May be 1, or an int, or a hash +if ($cachestring) { // Important: The following code is to avoid a page request by the browser and PHP CPU at each Dolibarr page access. // We are here when param cache=xxx to force a cache policy: // xxx=1 means cache of 3600s // xxx=abcdef or 123456789 means a cache of 1 week (the key will be modified to get break cache use) if (empty($dolibarr_nocache)) { - if (GETPOST('cache', 'alpha') != '1') { - $delaycache = 3600 * 24 * 7; - } else { - $delaycache = 3600; - } + $delaycache = ((is_numeric($cachestring) && (int) $cachestring > 1 && (int) $cachestring < 999999) ? $cachestring : '3600'); header('Cache-Control: max-age='.$delaycache.', public, must-revalidate'); header('Pragma: cache'); // This is to avoid to have Pragma: no-cache set by proxy or web server - header('Expires: '.gmdate('D, d M Y H:i:s', time() + $delaycache).' GMT'); // This is to avoid to have Expires set by proxy or web server + header('Expires: '.gmdate('D, d M Y H:i:s', time() + (int) $delaycache).' GMT'); // This is to avoid to have Expires set by proxy or web server } else { // If any cache on files were disable by config file (for test purpose) header('Cache-Control: no-cache'); diff --git a/htdocs/website/samples/wrapper.php b/htdocs/website/samples/wrapper.php index 51c6c2500bb..db6b93846f5 100644 --- a/htdocs/website/samples/wrapper.php +++ b/htdocs/website/samples/wrapper.php @@ -133,8 +133,10 @@ $cachestring = GETPOST("cache", 'aZ09'); // May be 1, or an int, or a hash if ($cachestring || image_format_supported($original_file) >= 0) { // Important: Following code is to avoid page request by browser and PHP CPU at // each Dolibarr page access. - header('Cache-Control: max-age='.((is_numeric($cachestring) && (int) $cachestring > 1 && (int) $cachestring < 999999) ? $cachestring : '3600').', public, must-revalidate'); + $delaycache = ((is_numeric($cachestring) && (int) $cachestring > 1 && (int) $cachestring < 999999) ? $cachestring : '3600'); + header('Cache-Control: max-age='.$cachedelay.', public, must-revalidate'); header('Pragma: cache'); // This is to avoid having Pragma: no-cache + header('Expires: '.gmdate('D, d M Y H:i:s', time() + (int) $delaycache).' GMT'); // This is to avoid to have Expires set by proxy or web server } $refname = basename(dirname($original_file)."/"); From 035c99589e6f3650ce935f809f607ad588c2e340 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20St=C5=99=C3=ADbrn=C3=BD?= <35335130+kubajznik@users.noreply.github.com> Date: Fri, 2 Aug 2024 12:07:12 +0200 Subject: [PATCH 07/32] add professional id 7-10 to mysoc --- htdocs/societe/class/societe.class.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/htdocs/societe/class/societe.class.php b/htdocs/societe/class/societe.class.php index 95a40d04e12..97a7adebb1b 100644 --- a/htdocs/societe/class/societe.class.php +++ b/htdocs/societe/class/societe.class.php @@ -4630,6 +4630,10 @@ class Societe extends CommonObject $this->idprof4 = getDolGlobalString('MAIN_INFO_RCS'); $this->idprof5 = getDolGlobalString('MAIN_INFO_PROFID5'); $this->idprof6 = getDolGlobalString('MAIN_INFO_PROFID6'); + $this->idprof7 = getDolGlobalString('MAIN_INFO_PROFID7'); + $this->idprof8 = getDolGlobalString('MAIN_INFO_PROFID8'); + $this->idprof9 = getDolGlobalString('MAIN_INFO_PROFID9'); + $this->idprof10 = getDolGlobalString('MAIN_INFO_PROFID10'); $this->tva_intra = getDolGlobalString('MAIN_INFO_TVAINTRA'); // VAT number, not necessarily INTRA. $this->managers = getDolGlobalString('MAIN_INFO_SOCIETE_MANAGERS'); $this->capital = is_numeric(getDolGlobalString('MAIN_INFO_CAPITAL')) ? (float) price2num(getDolGlobalString('MAIN_INFO_CAPITAL')) : 0; From ef387308c20750234a78cab44eecfe302bbda95a Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 01:36:59 +0100 Subject: [PATCH 08/32] Debug v21 - Fix cache delay --- htdocs/website/samples/wrapper.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/htdocs/website/samples/wrapper.php b/htdocs/website/samples/wrapper.php index db6b93846f5..2aaa9d67ba5 100644 --- a/htdocs/website/samples/wrapper.php +++ b/htdocs/website/samples/wrapper.php @@ -38,7 +38,6 @@ $limit = GETPOSTINT('limit'); if ($limit <= 0 || $limit > 100) { $limit = 20; } -$cachedelay = GETPOSTINT('cachedelay'); // The delay in second of the cache // Parameters for RSS $rss = GETPOST('rss', 'aZ09'); @@ -129,12 +128,11 @@ if (GETPOSTISSET('type')) { $original_file = str_replace("../", "/", $original_file); // Cache or not -$cachestring = GETPOST("cache", 'aZ09'); // May be 1, or an int, or a hash +$cachestring = GETPOST("cache", 'aZ09'); // May be 1, or an int (delay in second of the cache if < 999999, or a timestamp), or a hash if ($cachestring || image_format_supported($original_file) >= 0) { - // Important: Following code is to avoid page request by browser and PHP CPU at - // each Dolibarr page access. - $delaycache = ((is_numeric($cachestring) && (int) $cachestring > 1 && (int) $cachestring < 999999) ? $cachestring : '3600'); - header('Cache-Control: max-age='.$cachedelay.', public, must-revalidate'); + // Important: Following code is to avoid page request by browser and PHP CPU at each Dolibarr page access. + $delaycache = GETPOSTINT('cachedelay') ? GETPOSTINT('cachedelay') : ((is_numeric($cachestring) && (int) $cachestring > 1 && (int) $cachestring < 999999) ? $cachestring : '3600'); + header('Cache-Control: max-age='.$delaycache.', public, must-revalidate'); header('Pragma: cache'); // This is to avoid having Pragma: no-cache header('Expires: '.gmdate('D, d M Y H:i:s', time() + (int) $delaycache).' GMT'); // This is to avoid to have Expires set by proxy or web server } From 778482d4be21f3eec5dcefc8f61b83b8c720ce76 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 03:11:27 +0100 Subject: [PATCH 09/32] Fix bad link to payment (forum https://www.dolibarr.fr/forum/t/liens-de-paiement-sur-les-pdf/46733/28) --- htdocs/core/modules/facture/doc/pdf_crabe.modules.php | 2 +- htdocs/core/modules/facture/doc/pdf_octopus.modules.php | 2 +- htdocs/core/modules/facture/doc/pdf_sponge.modules.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/htdocs/core/modules/facture/doc/pdf_crabe.modules.php b/htdocs/core/modules/facture/doc/pdf_crabe.modules.php index 026b03ad970..ebbaedfbc06 100644 --- a/htdocs/core/modules/facture/doc/pdf_crabe.modules.php +++ b/htdocs/core/modules/facture/doc/pdf_crabe.modules.php @@ -1259,7 +1259,7 @@ class pdf_crabe extends ModelePDFFactures $langs->loadLangs(array('payment', 'paybox', 'stripe')); $servicename = $langs->transnoentities('Online'); - $paiement_url = getOnlinePaymentUrl('', 'invoice', $object->ref, '', '', ''); + $paiement_url = getOnlinePaymentUrl(0, 'invoice', $object->ref, '', '', ''); $linktopay = $langs->trans("ToOfferALinkForOnlinePayment", $servicename).' '.$outputlangs->transnoentities("ClickHere").''; $pdf->SetXY($this->marge_gauche, $posy); diff --git a/htdocs/core/modules/facture/doc/pdf_octopus.modules.php b/htdocs/core/modules/facture/doc/pdf_octopus.modules.php index c958a8549c9..2b06f336901 100644 --- a/htdocs/core/modules/facture/doc/pdf_octopus.modules.php +++ b/htdocs/core/modules/facture/doc/pdf_octopus.modules.php @@ -1462,7 +1462,7 @@ class pdf_octopus extends ModelePDFFactures $langs->loadLangs(array('payment', 'paybox', 'stripe')); $servicename = $langs->transnoentities('Online'); - $paiement_url = getOnlinePaymentUrl('', 'invoice', $object->ref, '', '', ''); + $paiement_url = getOnlinePaymentUrl(0, 'invoice', $object->ref, '', '', ''); $linktopay = $langs->trans("ToOfferALinkForOnlinePayment", $servicename).' '.$outputlangs->transnoentities("ClickHere").''; $pdf->SetXY($this->marge_gauche, $posy); diff --git a/htdocs/core/modules/facture/doc/pdf_sponge.modules.php b/htdocs/core/modules/facture/doc/pdf_sponge.modules.php index 548d40bcb72..620fc2cc8c2 100644 --- a/htdocs/core/modules/facture/doc/pdf_sponge.modules.php +++ b/htdocs/core/modules/facture/doc/pdf_sponge.modules.php @@ -1363,7 +1363,7 @@ class pdf_sponge extends ModelePDFFactures $langs->loadLangs(array('payment', 'paybox', 'stripe')); $servicename = $langs->transnoentities('Online'); - $paiement_url = getOnlinePaymentUrl('', 'invoice', $object->ref, '', '', ''); + $paiement_url = getOnlinePaymentUrl(0, 'invoice', $object->ref, '', '', ''); $linktopay = $langs->trans("ToOfferALinkForOnlinePayment", $servicename).' '.$outputlangs->transnoentities("ClickHere").''; $pdf->SetXY($this->marge_gauche, $posy); From f4244f44665c6f1413fc89c7dc5b3f9733fad877 Mon Sep 17 00:00:00 2001 From: Alexandre SPANGARO Date: Mon, 3 Mar 2025 06:24:28 +0100 Subject: [PATCH 10/32] NEW Invoice - Document - Add hook on action --- htdocs/compta/facture/document.php | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/htdocs/compta/facture/document.php b/htdocs/compta/facture/document.php index 4ccc9a98fbb..9155185c460 100644 --- a/htdocs/compta/facture/document.php +++ b/htdocs/compta/facture/document.php @@ -1,11 +1,12 @@ - * Copyright (C) 2004-2016 Laurent Destailleur - * Copyright (C) 2005 Marc Barilley / Ocebo - * Copyright (C) 2005-2011 Regis Houssin - * Copyright (C) 2013 Cédric Salvador - * Copyright (C) 2017 Ferran Marcet - * Copyright (C) 2017-2024 Frédéric France +/* Copyright (C) 2003-2007 Rodolphe Quiedeville + * Copyright (C) 2004-2016 Laurent Destailleur + * Copyright (C) 2005 Marc Barilley / Ocebo + * Copyright (C) 2005-2011 Regis Houssin + * Copyright (C) 2013 Cédric Salvador + * Copyright (C) 2017 Ferran Marcet + * Copyright (C) 2017-2024 Frédéric France + * Copyright (C) 2025 Alexandre Spangaro * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -97,7 +98,14 @@ $usercancreate = $user->hasRight("facture", "creer"); * Actions */ -include DOL_DOCUMENT_ROOT.'/core/actions_linkedfiles.inc.php'; +$parameters = array('id' => $id); +$reshook = $hookmanager->executeHooks('doActions', $parameters, $object, $action); // Note that $action and $object may have been modified by some hooks +if ($reshook < 0) { + setEventMessages($hookmanager->error, $hookmanager->errors, 'errors'); +} +if (empty($reshook)) { + include DOL_DOCUMENT_ROOT.'/core/actions_linkedfiles.inc.php'; +} /* From 3c223f82c36ae37fe80d1b0783c652c85968af3f Mon Sep 17 00:00:00 2001 From: Alexandre SPANGARO Date: Mon, 3 Mar 2025 06:49:58 +0100 Subject: [PATCH 11/32] FIX #20716 Upload SVG in editor --- htdocs/admin/company.php | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/htdocs/admin/company.php b/htdocs/admin/company.php index 1e2757154a5..bdf19e2cfae 100644 --- a/htdocs/admin/company.php +++ b/htdocs/admin/company.php @@ -1,13 +1,13 @@ - * Copyright (C) 2004-2019 Laurent Destailleur - * Copyright (C) 2005-2017 Regis Houssin - * Copyright (C) 2010-2014 Juanjo Menent - * Copyright (C) 2011-2017 Philippe Grand - * Copyright (C) 2015 Alexandre Spangaro - * Copyright (C) 2017 Rui Strecht - * Copyright (C) 2023 Nick Fragoulis - * Copyright (C) 2024-2025 Frédéric France +/* Copyright (C) 2001-2007 Rodolphe Quiedeville + * Copyright (C) 2004-2019 Laurent Destailleur + * Copyright (C) 2005-2017 Regis Houssin + * Copyright (C) 2010-2014 Juanjo Menent + * Copyright (C) 2011-2017 Philippe Grand + * Copyright (C) 2015-2025 Alexandre Spangaro + * Copyright (C) 2017 Rui Strecht + * Copyright (C) 2023 Nick Fragoulis + * Copyright (C) 2024-2025 Frédéric France * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify @@ -137,7 +137,7 @@ if (($action == 'update' && !GETPOST("cancel", 'alpha')) $arrayofimages = array('logo', 'logo_squarred'); //var_dump($_FILES); exit; foreach ($arrayofimages as $varforimage) { - if ($_FILES[$varforimage]["name"] && !preg_match('/(\.jpeg|\.jpg|\.png)$/i', $_FILES[$varforimage]["name"])) { // Logo can be used on a lot of different places. Only jpg and png can be supported. + if ($_FILES[$varforimage]["name"] && !image_format_supported($_FILES[$varforimage]["name"], 1)) { // Logo can be used on a lot of different places. Recommend using jpg and png for better compatibility. $langs->load("errors"); setEventMessages($langs->trans("ErrorBadImageFormat"), null, 'errors'); break; From 06854f00e5a52e57d8fa61b83314d1c199c925ec Mon Sep 17 00:00:00 2001 From: John BOTELLA <68917336+thersane-john@users.noreply.github.com> Date: Mon, 3 Mar 2025 07:34:42 +0100 Subject: [PATCH 12/32] change type var in comment --- htdocs/core/class/html.formsetup.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/core/class/html.formsetup.class.php b/htdocs/core/class/html.formsetup.class.php index 392fa8232c1..b4eae28beb0 100644 --- a/htdocs/core/class/html.formsetup.class.php +++ b/htdocs/core/class/html.formsetup.class.php @@ -615,7 +615,7 @@ class FormSetupItem /** @var string $picto */ public $picto = ''; - /** @var string $fieldValue */ + /** @var string|null $fieldValue */ public $fieldValue; /** @var string $defaultFieldValue */ From 7e03e72790d4240908b5ebc9968cf98b75c6c1d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?= Date: Mon, 3 Mar 2025 10:02:08 +0100 Subject: [PATCH 13/32] add missing translation --- dev/translation/ignore_translation_keys.lst | 1 - htdocs/user/virtualcard.php | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dev/translation/ignore_translation_keys.lst b/dev/translation/ignore_translation_keys.lst index 2899c91805e..4f73debc3c7 100644 --- a/dev/translation/ignore_translation_keys.lst +++ b/dev/translation/ignore_translation_keys.lst @@ -988,7 +988,6 @@ Analytic AnalyticLabel BankId Bcc -Birthdate Candidature ClientCollation Collation diff --git a/htdocs/user/virtualcard.php b/htdocs/user/virtualcard.php index 7b2205f7824..cfb1a46a1aa 100644 --- a/htdocs/user/virtualcard.php +++ b/htdocs/user/virtualcard.php @@ -1,7 +1,7 @@ * Copyright (C) 2005-2015 Regis Houssin - * Copyright (C) 2024 Frédéric France + * Copyright (C) 2024-2025 Frédéric France * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -278,7 +278,7 @@ if (getDolUserInt('USER_ENABLE_PUBLIC', 0, $object)) { // Birth date print ''; - print $langs->trans("ShowOnVCard", $langs->transnoentitiesnoconv("Birthdate")); + print $langs->trans("ShowOnVCard", $langs->transnoentitiesnoconv("DateOfBirth")); print ''; print ajax_constantonoff("USER_PUBLIC_SHOW_BIRTH", array(), null, 0, 0, 1, 2, 0, 0, '', '', 'reposition', $object); print "\n"; From 3e2d57c19a52eaa158b34e42c06ba917c4bbf9cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?= Date: Mon, 3 Mar 2025 10:05:07 +0100 Subject: [PATCH 14/32] add missing translation --- dev/translation/ignore_translation_keys.lst | 1 - htdocs/compta/facture/class/facture.class.php | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dev/translation/ignore_translation_keys.lst b/dev/translation/ignore_translation_keys.lst index 4f73debc3c7..d4ae6fef13e 100644 --- a/dev/translation/ignore_translation_keys.lst +++ b/dev/translation/ignore_translation_keys.lst @@ -1005,7 +1005,6 @@ ErrorLDAPFunctionsAreDisabledOnThisPHP ErrorUpdating Exceptions Extra -Facture FailedToConnectToSFTPAfterSSHAuthentication FailedToLogin First diff --git a/htdocs/compta/facture/class/facture.class.php b/htdocs/compta/facture/class/facture.class.php index e0637070717..87806a770c7 100644 --- a/htdocs/compta/facture/class/facture.class.php +++ b/htdocs/compta/facture/class/facture.class.php @@ -5797,7 +5797,7 @@ class Facture extends CommonInvoice $langs->load("bills"); if (!isModEnabled('invoice')) { // Should not happen. If module disabled, cron job should not be visible. - $this->output .= $langs->trans('ModuleNotEnabled', $langs->transnoentitiesnoconv("Facture")); + $this->output .= $langs->trans('ModuleNotEnabled', $langs->transnoentitiesnoconv("Invoice")); return 0; } if (!in_array($datetouse, array('duedate', 'invoicedate'))) { @@ -5806,7 +5806,7 @@ class Facture extends CommonInvoice } /*if (empty($conf->global->FACTURE_REMINDER_EMAIL)) { $langs->load("bills"); - $this->output .= $langs->trans('EventRemindersByEmailNotEnabled', $langs->transnoentitiesnoconv("Facture")); + $this->output .= $langs->trans('EventRemindersByEmailNotEnabled', $langs->transnoentitiesnoconv("Invoice")); return 0; } */ From 2003a5c26378d3498d796b6667ae18dd2fc47158 Mon Sep 17 00:00:00 2001 From: Jyhere Date: Mon, 3 Mar 2025 10:54:19 +0100 Subject: [PATCH 15/32] FIX: migration file Update 21.0.0-22.0.0.sql syntax error Fix the following DB errors when updating : DB_ERROR_SYNTAX (Req 70): ALTER TABLE llx_product_customer_price DROP CONSTRAINT fk_product_customer_price_fk_product; DB_ERROR_SYNTAX (Req 71): ALTER TABLE llx_product_customer_price DROP CONSTRAINT fk_product_customer_price_fk_soc; --- htdocs/install/mysql/migration/21.0.0-22.0.0.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/install/mysql/migration/21.0.0-22.0.0.sql b/htdocs/install/mysql/migration/21.0.0-22.0.0.sql index 25b303514d6..0a8e165d6c9 100644 --- a/htdocs/install/mysql/migration/21.0.0-22.0.0.sql +++ b/htdocs/install/mysql/migration/21.0.0-22.0.0.sql @@ -184,8 +184,8 @@ ALTER TABLE llx_product_customer_price ADD COLUMN discount_percent real DEFAULT ALTER TABLE llx_product_customer_price_log ADD COLUMN date_begin date AFTER ref_customer; ALTER TABLE llx_product_customer_price_log ADD COLUMN date_end date AFTER date_begin; ALTER TABLE llx_product_customer_price_log ADD COLUMN discount_percent real DEFAULT 0 AFTER localtax2_type; -ALTER TABLE llx_product_customer_price DROP CONSTRAINT fk_product_customer_price_fk_product; -ALTER TABLE llx_product_customer_price DROP CONSTRAINT fk_product_customer_price_fk_soc; +ALTER TABLE llx_product_customer_price DROP FOREIGN KEY fk_product_customer_price_fk_product; +ALTER TABLE llx_product_customer_price DROP FOREIGN KEY fk_product_customer_price_fk_soc; ALTER TABLE llx_product_customer_price DROP INDEX uk_customer_price_fk_product_fk_soc; ALTER TABLE llx_product_customer_price ADD UNIQUE INDEX uk_customer_price_fk_product_fk_soc (fk_product, fk_soc, date_begin); ALTER TABLE llx_product_customer_price ADD CONSTRAINT fk_product_customer_price_fk_product FOREIGN KEY (fk_product) REFERENCES llx_product(rowid); From 31d8a66a1c6d8a57b6c046a7703c877b50bfbc92 Mon Sep 17 00:00:00 2001 From: EchoLoGeek <73399671+EchoLoGeek@users.noreply.github.com> Date: Mon, 3 Mar 2025 11:24:33 +0100 Subject: [PATCH 16/32] Remain to pay in multicurrency If I want to have the remainder to pay in foreign currency, I must deduct it from the amount in multicurrency, not the amount in conf->currency --- htdocs/core/class/commoninvoice.class.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/htdocs/core/class/commoninvoice.class.php b/htdocs/core/class/commoninvoice.class.php index 8d8fff229b8..780f65fd31c 100644 --- a/htdocs/core/class/commoninvoice.class.php +++ b/htdocs/core/class/commoninvoice.class.php @@ -291,7 +291,12 @@ abstract class CommonInvoice extends CommonObject $alreadypaid += $this->getSumDepositsUsed($multicurrency); $alreadypaid += $this->getSumCreditNotesUsed($multicurrency); - $remaintopay = price2num($this->total_ttc - $alreadypaid, 'MT'); + if((int) $multicurrency > 0){ + $totalamount = $this->multicurrency_total_ttc; + } else { + $totalamount = $this->total_ttc; + } + $remaintopay = price2num($totalamount - $alreadypaid, 'MT'); if ($this->status == self::STATUS_CLOSED && $this->close_code == 'discount_vat') { // If invoice closed with discount for anticipated payment $remaintopay = 0.0; } From 09a31362da96ae69796ac4ee7674709714704758 Mon Sep 17 00:00:00 2001 From: Jyhere Date: Mon, 3 Mar 2025 11:27:48 +0100 Subject: [PATCH 17/32] FIX ; 21.0.0-22.0.0.sql sql error in some case FIX the following error if Dolibarr first installed version was <= 3.5 : Cannot drop index 'uk_customer_price_fk_product_fk_soc': needed in a foreign key constraint --- htdocs/install/mysql/migration/21.0.0-22.0.0.sql | 2 ++ 1 file changed, 2 insertions(+) diff --git a/htdocs/install/mysql/migration/21.0.0-22.0.0.sql b/htdocs/install/mysql/migration/21.0.0-22.0.0.sql index 0a8e165d6c9..e97145bcb0a 100644 --- a/htdocs/install/mysql/migration/21.0.0-22.0.0.sql +++ b/htdocs/install/mysql/migration/21.0.0-22.0.0.sql @@ -186,6 +186,8 @@ ALTER TABLE llx_product_customer_price_log ADD COLUMN date_end date AFTER date_b ALTER TABLE llx_product_customer_price_log ADD COLUMN discount_percent real DEFAULT 0 AFTER localtax2_type; ALTER TABLE llx_product_customer_price DROP FOREIGN KEY fk_product_customer_price_fk_product; ALTER TABLE llx_product_customer_price DROP FOREIGN KEY fk_product_customer_price_fk_soc; +ALTER TABLE llx_product_customer_price DROP FOREIGN KEY fk_customer_price_fk_product; +ALTER TABLE llx_product_customer_price DROP FOREIGN KEY fk_customer_price_fk_soc; ALTER TABLE llx_product_customer_price DROP INDEX uk_customer_price_fk_product_fk_soc; ALTER TABLE llx_product_customer_price ADD UNIQUE INDEX uk_customer_price_fk_product_fk_soc (fk_product, fk_soc, date_begin); ALTER TABLE llx_product_customer_price ADD CONSTRAINT fk_product_customer_price_fk_product FOREIGN KEY (fk_product) REFERENCES llx_product(rowid); From 580e422bf52674c1470e69a5800ddb4211db4959 Mon Sep 17 00:00:00 2001 From: EchoLoGeek <73399671+EchoLoGeek@users.noreply.github.com> Date: Mon, 3 Mar 2025 11:39:18 +0100 Subject: [PATCH 18/32] fix spaces --- htdocs/core/class/commoninvoice.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/core/class/commoninvoice.class.php b/htdocs/core/class/commoninvoice.class.php index 780f65fd31c..a2a431b00db 100644 --- a/htdocs/core/class/commoninvoice.class.php +++ b/htdocs/core/class/commoninvoice.class.php @@ -291,7 +291,7 @@ abstract class CommonInvoice extends CommonObject $alreadypaid += $this->getSumDepositsUsed($multicurrency); $alreadypaid += $this->getSumCreditNotesUsed($multicurrency); - if((int) $multicurrency > 0){ + if ((int) $multicurrency > 0) { $totalamount = $this->multicurrency_total_ttc; } else { $totalamount = $this->total_ttc; From cc71865f3ce1af86dc04fed0624c1ccb338d9084 Mon Sep 17 00:00:00 2001 From: Dolibot Date: Mon, 3 Mar 2025 12:06:49 +0000 Subject: [PATCH 19/32] PHPStan > Update baseline --- dev/build/phpstan/phpstan-baseline.neon | 1416 +---------------------- 1 file changed, 3 insertions(+), 1413 deletions(-) diff --git a/dev/build/phpstan/phpstan-baseline.neon b/dev/build/phpstan/phpstan-baseline.neon index 98d170efd4c..ce8c2a8fa80 100644 --- a/dev/build/phpstan/phpstan-baseline.neon +++ b/dev/build/phpstan/phpstan-baseline.neon @@ -1722,12 +1722,6 @@ parameters: count: 1 path: ../../../htdocs/admin/system/filecheck.php - - - message: '#^Parameter \#1 \$file_list of function getFilesUpdated expects array\{insignature\: array\, missing\?\: array\, updated\: array\\}, array\{\} given\.$#' - identifier: argument.type - count: 1 - path: ../../../htdocs/admin/system/filecheck.php - - message: '#^Parameter \#1 \$size of function dol_print_size expects int, string given\.$#' identifier: argument.type @@ -2028,12 +2022,6 @@ parameters: count: 1 path: ../../../htdocs/api/class/api.class.php - - - message: '#^Method DolibarrApiAccess\:\:verifyAccess\(\) has parameter \$m with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_access.class.php - - message: '#^Property DolibarrApiAccess\:\:\$requires type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -2052,36 +2040,6 @@ parameters: count: 1 path: ../../../htdocs/api/class/api_documents.class.php - - - message: '#^Method Documents\:\:builddoc\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_documents.class.php - - - - message: '#^Method Documents\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_documents.class.php - - - - message: '#^Method Documents\:\:getDocumentsListByElement\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_documents.class.php - - - - message: '#^Method Documents\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_documents.class.php - - - - message: '#^Method Documents\:\:post\(\) has parameter \$array_options with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_documents.class.php - - message: '#^Negated boolean expression is always true\.$#' identifier: booleanNot.alwaysTrue @@ -2100,24 +2058,6 @@ parameters: count: 1 path: ../../../htdocs/api/class/api_documents.class.php - - - message: '#^Method Login\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_login.class.php - - - - message: '#^Method Login\:\:loginUnsecured\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_login.class.php - - - - message: '#^Method Setup\:\:getModules\(\) should return array\ but returns object\.$#' - identifier: return.type - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - message: '#^Comparison operation "\<\=" between 0 and 0 is always true\.$#' identifier: smallerOrEqual.alwaysTrue @@ -2131,194 +2071,8 @@ parameters: path: ../../../htdocs/api/class/api_setup.class.php - - message: '#^Method Setup\:\:deleteExtrafieldsFromNames\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getAvailability\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getCheckIntegrity\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getEstablishments\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getExtrafields\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfCivilities\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfContactTypes\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfCountries\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfCurrencies\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfEventTypes\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfExpenseReportsTypes\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfExtrafields\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfIncoterms\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfLegalForm\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfMeasuringUnits\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfRegions\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfStaff\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfStates\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfTowns\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getListOfsocialNetworks\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getOrderingMethods\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getOrderingOrigins\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getPaymentTerms\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getPaymentTypes\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getShippingModes\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getTicketsCategories\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getTicketsSeverities\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:getTicketsTypes\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:postExtrafields\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:translateLabel\(\) has parameter \$dict with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Method Setup\:\:updateExtrafields\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_setup.class.php - - - - message: '#^Parameter \#1 \$file_list of function getFilesUpdated expects array\{insignature\: array\, missing\?\: array\, updated\: array\\}, array\{\} given\.$#' - identifier: argument.type + message: '#^Method Setup\:\:getModules\(\) should return array\ but returns object\.$#' + identifier: return.type count: 1 path: ../../../htdocs/api/class/api_setup.class.php @@ -2340,12 +2094,6 @@ parameters: count: 1 path: ../../../htdocs/api/class/api_setup.class.php - - - message: '#^Method Status\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/api/class/api_status.class.php - - message: '#^Negated boolean expression is always true\.$#' identifier: booleanNot.alwaysTrue @@ -2790,66 +2538,6 @@ parameters: count: 3 path: ../../../htdocs/bom/class/api_boms.class.php - - - message: '#^Method Boms\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:deleteLine\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:getLines\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:postLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - - - message: '#^Method Boms\:\:putLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/bom/class/api_boms.class.php - - message: '#^Result of && is always false\.$#' identifier: booleanAnd.alwaysFalse @@ -3396,24 +3084,6 @@ parameters: count: 1 path: ../../../htdocs/categories/card.php - - - message: '#^Method Categories\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/categories/class/api_categories.class.php - - - - message: '#^Method Categories\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/categories/class/api_categories.class.php - - - - message: '#^Method Categories\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/categories/class/api_categories.class.php - - message: '#^Method Categories\:\:getListForObject\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -3438,18 +3108,6 @@ parameters: count: 1 path: ../../../htdocs/categories/class/api_categories.class.php - - - message: '#^Method Categories\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/categories/class/api_categories.class.php - - - - message: '#^Method Categories\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/categories/class/api_categories.class.php - - message: '#^Method Categories\:\:unlinkObjectById\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -3618,42 +3276,12 @@ parameters: count: 2 path: ../../../htdocs/comm/action/class/actioncomm.class.php - - - message: '#^Method AgendaEvents\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/action/class/api_agendaevents.class.php - - - - message: '#^Method AgendaEvents\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/action/class/api_agendaevents.class.php - - - - message: '#^Method AgendaEvents\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/action/class/api_agendaevents.class.php - - message: '#^Method AgendaEvents\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/comm/action/class/api_agendaevents.class.php - - - message: '#^Method AgendaEvents\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/action/class/api_agendaevents.class.php - - - - message: '#^Method AgendaEvents\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/action/class/api_agendaevents.class.php - - message: '#^Left side of && is always true\.$#' identifier: booleanAnd.leftAlwaysTrue @@ -4194,24 +3822,6 @@ parameters: count: 1 path: ../../../htdocs/comm/propal/card.php - - - message: '#^Method Proposals\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - - - message: '#^Method Proposals\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - - - message: '#^Method Proposals\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - message: '#^Method Proposals\:\:getLines\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -4224,42 +3834,12 @@ parameters: count: 1 path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - - message: '#^Method Proposals\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - message: '#^Method Proposals\:\:postContact\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - - message: '#^Method Proposals\:\:postLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - - - message: '#^Method Proposals\:\:postLines\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - - - message: '#^Method Proposals\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - - - message: '#^Method Proposals\:\:putLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/comm/propal/class/api_proposals.class.php - - message: '#^Negated boolean expression is always false\.$#' identifier: booleanNot.alwaysFalse @@ -4584,30 +4164,6 @@ parameters: count: 6 path: ../../../htdocs/commande/card.php - - - message: '#^Method Orders\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - - - message: '#^Method Orders\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - - - message: '#^Method Orders\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - - - message: '#^Method Orders\:\:deleteContact\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - message: '#^Method Orders\:\:getLines\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -4626,36 +4182,6 @@ parameters: count: 1 path: ../../../htdocs/commande/class/api_orders.class.php - - - message: '#^Method Orders\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - - - message: '#^Method Orders\:\:postContact\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - - - message: '#^Method Orders\:\:postLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - - - message: '#^Method Orders\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - - - message: '#^Method Orders\:\:putLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/commande/class/api_orders.class.php - - message: '#^Negated boolean expression is always false\.$#' identifier: booleanNot.alwaysFalse @@ -5076,30 +4602,6 @@ parameters: count: 2 path: ../../../htdocs/compta/bank/class/account.class.php - - - message: '#^Method BankAccounts\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - - - message: '#^Method BankAccounts\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - - - message: '#^Method BankAccounts\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - - - message: '#^Method BankAccounts\:\:deleteLine\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - message: '#^Method BankAccounts\:\:getLines\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -5118,24 +4620,6 @@ parameters: count: 1 path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - - message: '#^Method BankAccounts\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - - - message: '#^Method BankAccounts\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - - - message: '#^Method BankAccounts\:\:transfer\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/bank/class/api_bankaccounts.class.php - - message: '#^Negated boolean expression is always true\.$#' identifier: booleanNot.alwaysTrue @@ -5580,30 +5064,6 @@ parameters: count: 1 path: ../../../htdocs/compta/facture/card.php - - - message: '#^Method Invoices\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:addPaymentDistributed\(\) has parameter \$arrayofamounts with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - message: '#^Method Invoices\:\:getLines\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -5622,42 +5082,6 @@ parameters: count: 1 path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - message: '#^Method Invoices\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:postContact\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:postLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:putLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - - - message: '#^Method Invoices\:\:putPayment\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/compta/facture/class/api_invoices.class.php - - message: '#^Negated boolean expression is always false\.$#' identifier: booleanNot.alwaysFalse @@ -7542,30 +6966,6 @@ parameters: count: 1 path: ../../../htdocs/contrat/card.php - - - message: '#^Method Contracts\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - - - message: '#^Method Contracts\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - - - message: '#^Method Contracts\:\:close\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - - - message: '#^Method Contracts\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - message: '#^Method Contracts\:\:getLines\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -7578,36 +6978,6 @@ parameters: count: 1 path: ../../../htdocs/contrat/class/api_contracts.class.php - - - message: '#^Method Contracts\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - - - message: '#^Method Contracts\:\:postLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - - - message: '#^Method Contracts\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - - - message: '#^Method Contracts\:\:putLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - - - message: '#^Method Contracts\:\:validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/contrat/class/api_contracts.class.php - - message: '#^Property Contracts\:\:\$FIELDS type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -14976,42 +14346,12 @@ parameters: count: 1 path: ../../../htdocs/document.php - - - message: '#^Method Donations\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/don/class/api_donations.class.php - - - - message: '#^Method Donations\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/don/class/api_donations.class.php - - - - message: '#^Method Donations\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/don/class/api_donations.class.php - - message: '#^Method Donations\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/don/class/api_donations.class.php - - - message: '#^Method Donations\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/don/class/api_donations.class.php - - - - message: '#^Method Donations\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/don/class/api_donations.class.php - - message: '#^Negated boolean expression is always false\.$#' identifier: booleanNot.alwaysFalse @@ -15858,54 +15198,6 @@ parameters: count: 1 path: ../../../htdocs/expedition/card.php - - - message: '#^Method Shipments\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - - - message: '#^Method Shipments\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - - - message: '#^Method Shipments\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - - - message: '#^Method Shipments\:\:deleteLine\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - - - message: '#^Method Shipments\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - - - message: '#^Method Shipments\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - - - message: '#^Method Shipments\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - - - message: '#^Property Shipments\:\:\$FIELDS type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expedition/class/api_shipments.class.php - - message: '#^Call to function method_exists\(\) with \$this\(Expedition\) and ''getLibStatut'' will always evaluate to true\.$#' identifier: function.alreadyNarrowedType @@ -16251,7 +15543,7 @@ parameters: - message: '#^If condition is always true\.$#' identifier: if.alwaysTrue - count: 6 + count: 5 path: ../../../htdocs/expensereport/card.php - @@ -16290,84 +15582,6 @@ parameters: count: 10 path: ../../../htdocs/expensereport/card.php - - - message: '#^Method ExpenseReports\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:_validatepayment\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:_validatepayment\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:addPayment\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:getAllPayments\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Method ExpenseReports\:\:updatePayment\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Property ExpenseReports\:\:\$FIELDS type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - - - message: '#^Property ExpenseReports\:\:\$FIELDSPAYMENT has no type specified\.$#' - identifier: missingType.property - count: 1 - path: ../../../htdocs/expensereport/class/api_expensereports.class.php - - message: '#^Call to function method_exists\(\) with \$this\(ExpenseReport\) and ''getLibStatut'' will always evaluate to true\.$#' identifier: function.alreadyNarrowedType @@ -16830,30 +16044,6 @@ parameters: count: 1 path: ../../../htdocs/fourn/card.php - - - message: '#^Method SupplierInvoices\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierInvoices\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierInvoices\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierInvoices\:\:deleteLine\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - message: '#^Method SupplierInvoices\:\:getLines\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -16872,114 +16062,6 @@ parameters: count: 1 path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - message: '#^Method SupplierInvoices\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierInvoices\:\:postLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierInvoices\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierInvoices\:\:putLine\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierInvoices\:\:validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_invoices.class.php - - - - message: '#^Method SupplierOrders\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:approve\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:deleteContact\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:makeOrder\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:postContact\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:receiveOrder\(\) has parameter \$lines with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:receiveOrder\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - - - message: '#^Method SupplierOrders\:\:validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/fourn/class/api_supplier_orders.class.php - - message: '#^Parameter \#1 \$object of method SupplierOrders\:\:_cleanObjectDatas\(\) expects object, array\ given\.$#' identifier: argument.type @@ -19266,42 +18348,12 @@ parameters: count: 3 path: ../../../htdocs/knowledgemanagement/class/api_knowledgemanagement.class.php - - - message: '#^Method KnowledgeManagement\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/knowledgemanagement/class/api_knowledgemanagement.class.php - - - - message: '#^Method KnowledgeManagement\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/knowledgemanagement/class/api_knowledgemanagement.class.php - - - - message: '#^Method KnowledgeManagement\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/knowledgemanagement/class/api_knowledgemanagement.class.php - - message: '#^Method KnowledgeManagement\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/knowledgemanagement/class/api_knowledgemanagement.class.php - - - message: '#^Method KnowledgeManagement\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/knowledgemanagement/class/api_knowledgemanagement.class.php - - - - message: '#^Method KnowledgeManagement\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/knowledgemanagement/class/api_knowledgemanagement.class.php - - message: '#^Result of && is always false\.$#' identifier: booleanAnd.alwaysFalse @@ -20652,36 +19704,12 @@ parameters: count: 1 path: ../../../htdocs/mrp/tpl/linkedobjectblock.tpl.php - - - message: '#^Method MultiCurrencies\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/multicurrency/class/api_multicurrencies.class.php - - message: '#^Method MultiCurrencies\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/multicurrency/class/api_multicurrencies.class.php - - - message: '#^Method MultiCurrencies\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/multicurrency/class/api_multicurrencies.class.php - - - - message: '#^Method MultiCurrencies\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/multicurrency/class/api_multicurrencies.class.php - - - - message: '#^Method MultiCurrencies\:\:updateRate\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/multicurrency/class/api_multicurrencies.class.php - - message: '#^Parameter \#1 \$object of method MultiCurrencies\:\:_cleanObjectDatasRate\(\) expects MultiCurrency, CurrencyRate given\.$#' identifier: argument.type @@ -20808,42 +19836,12 @@ parameters: count: 3 path: ../../../htdocs/partnership/class/api_partnerships.class.php - - - message: '#^Method Partnerships\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/partnership/class/api_partnerships.class.php - - - - message: '#^Method Partnerships\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/partnership/class/api_partnerships.class.php - - - - message: '#^Method Partnerships\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/partnership/class/api_partnerships.class.php - - message: '#^Method Partnerships\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/partnership/class/api_partnerships.class.php - - - message: '#^Method Partnerships\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/partnership/class/api_partnerships.class.php - - - - message: '#^Method Partnerships\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/partnership/class/api_partnerships.class.php - - message: '#^Result of && is always false\.$#' identifier: booleanAnd.alwaysFalse @@ -21174,42 +20172,6 @@ parameters: count: 1 path: ../../../htdocs/product/class/api_products.class.php - - - message: '#^Method Products\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:addPurchasePrice\(\) has parameter \$localtaxes_array with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:addVariant\(\) has parameter \$features with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:addVariantByProductRef\(\) has parameter \$features with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - message: '#^Method Products\:\:getAttributeValueById\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -21282,36 +20244,6 @@ parameters: count: 1 path: ../../../htdocs/product/class/api_products.class.php - - - message: '#^Method Products\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:putAttributeValue\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:putAttributes\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - - - message: '#^Method Products\:\:putVariant\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/class/api_products.class.php - - message: '#^Parameter \#1 \$object of method Products\:\:_cleanObjectDatas\(\) expects object, array\\|int given\.$#' identifier: argument.type @@ -22122,42 +21054,12 @@ parameters: count: 1 path: ../../../htdocs/product/stock/class/api_stockmovements.class.php - - - message: '#^Method Warehouses\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/stock/class/api_warehouses.class.php - - - - message: '#^Method Warehouses\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/stock/class/api_warehouses.class.php - - - - message: '#^Method Warehouses\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/stock/class/api_warehouses.class.php - - message: '#^Method Warehouses\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/product/stock/class/api_warehouses.class.php - - - message: '#^Method Warehouses\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/stock/class/api_warehouses.class.php - - - - message: '#^Method Warehouses\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/product/stock/class/api_warehouses.class.php - - message: '#^Property Warehouses\:\:\$FIELDS type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -22890,36 +21792,6 @@ parameters: count: 1 path: ../../../htdocs/projet/class/api_projects.class.php - - - message: '#^Method Tasks\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - - - message: '#^Method Tasks\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - - - message: '#^Method Tasks\:\:addTimeSpent\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - - - message: '#^Method Tasks\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - - - message: '#^Method Tasks\:\:deleteTimeSpent\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - message: '#^Method Tasks\:\:getRoles\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -22932,24 +21804,6 @@ parameters: count: 1 path: ../../../htdocs/projet/class/api_tasks.class.php - - - message: '#^Method Tasks\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - - - message: '#^Method Tasks\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - - - message: '#^Method Tasks\:\:putTimeSpent\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/projet/class/api_tasks.class.php - - message: '#^Parameter \#1 \$object of method Tasks\:\:_cleanObjectDatas\(\) expects object, string given\.$#' identifier: argument.type @@ -25632,36 +24486,6 @@ parameters: count: 1 path: ../../../htdocs/salaries/card.php - - - message: '#^Method Salaries\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - - - message: '#^Method Salaries\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - - - message: '#^Method Salaries\:\:_validatepayments\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - - - message: '#^Method Salaries\:\:_validatepayments\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - - - message: '#^Method Salaries\:\:addPayment\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - message: '#^Method Salaries\:\:getAllPayments\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -25674,24 +24498,6 @@ parameters: count: 1 path: ../../../htdocs/salaries/class/api_salaries.class.php - - - message: '#^Method Salaries\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - - - message: '#^Method Salaries\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - - - message: '#^Method Salaries\:\:updatePayment\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/salaries/class/api_salaries.class.php - - message: '#^Property Salaries\:\:\$FIELDS type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -26052,48 +24858,6 @@ parameters: count: 1 path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - message: '#^Method Thirdparties\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:createCompanyBankAccount\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:createCompanyNotification\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:createCompanyNotificationByCode\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:createSocieteAccount\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - message: '#^Method Thirdparties\:\:generateBankAccountDocument\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -26166,42 +24930,6 @@ parameters: count: 1 path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - message: '#^Method Thirdparties\:\:patchSocieteAccount\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:putSocieteAccount\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:updateCompanyBankAccount\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - - - message: '#^Method Thirdparties\:\:updateCompanyNotification\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/societe/class/api_thirdparties.class.php - - message: '#^Property Societe\:\:\$default_lang \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -26616,42 +25344,12 @@ parameters: count: 4 path: ../../../htdocs/supplier_proposal/card.php - - - message: '#^Method SupplierProposals\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/supplier_proposal/class/api_supplier_proposals.class.php - - - - message: '#^Method SupplierProposals\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/supplier_proposal/class/api_supplier_proposals.class.php - - - - message: '#^Method SupplierProposals\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/supplier_proposal/class/api_supplier_proposals.class.php - - message: '#^Method SupplierProposals\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/supplier_proposal/class/api_supplier_proposals.class.php - - - message: '#^Method SupplierProposals\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/supplier_proposal/class/api_supplier_proposals.class.php - - - - message: '#^Method SupplierProposals\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/supplier_proposal/class/api_supplier_proposals.class.php - - message: '#^Property SupplierProposals\:\:\$FIELDS type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -27072,60 +25770,12 @@ parameters: count: 1 path: ../../../htdocs/ticket/card.php - - - message: '#^Method Tickets\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - - - message: '#^Method Tickets\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - - - message: '#^Method Tickets\:\:_validateMessage\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - - - message: '#^Method Tickets\:\:_validateMessage\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - - - message: '#^Method Tickets\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - message: '#^Method Tickets\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue count: 1 path: ../../../htdocs/ticket/class/api_tickets.class.php - - - message: '#^Method Tickets\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - - - message: '#^Method Tickets\:\:postNewMessage\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - - - message: '#^Method Tickets\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/ticket/class/api_tickets.class.php - - message: '#^Property Tickets\:\:\$FIELDS type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -27912,24 +26562,6 @@ parameters: count: 1 path: ../../../htdocs/viewimage.php - - - message: '#^Method Webhook\:\:_validate\(\) has parameter \$data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/webhook/class/api_webhook.class.php - - - - message: '#^Method Webhook\:\:_validate\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/webhook/class/api_webhook.class.php - - - - message: '#^Method Webhook\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/webhook/class/api_webhook.class.php - - message: '#^Method Webhook\:\:index\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -27942,18 +26574,6 @@ parameters: count: 1 path: ../../../htdocs/webhook/class/api_webhook.class.php - - - message: '#^Method Webhook\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/webhook/class/api_webhook.class.php - - - - message: '#^Method Webhook\:\:put\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/webhook/class/api_webhook.class.php - - message: '#^Property Webhook\:\:\$FIELDS type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue @@ -28590,36 +27210,6 @@ parameters: count: 3 path: ../../../htdocs/zapier/class/api_zapier.class.php - - - message: '#^Method Zapier\:\:delete\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/zapier/class/api_zapier.class.php - - - - message: '#^Method Zapier\:\:getModulesChoices\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/zapier/class/api_zapier.class.php - - - - message: '#^Method Zapier\:\:index\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/zapier/class/api_zapier.class.php - - - - message: '#^Method Zapier\:\:post\(\) has parameter \$request_data with no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/zapier/class/api_zapier.class.php - - - - message: '#^Method Zapier\:\:post\(\) return type has no value type specified in iterable type array\.$#' - identifier: missingType.iterableValue - count: 1 - path: ../../../htdocs/zapier/class/api_zapier.class.php - - message: '#^Property Zapier\:\:\$FIELDS type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue From 58d1bdfbceeaa88be4ac3c6d3e1a96fc4721cca9 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 13:51:47 +0100 Subject: [PATCH 20/32] Doc --- htdocs/core/lib/pdf.lib.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/htdocs/core/lib/pdf.lib.php b/htdocs/core/lib/pdf.lib.php index e590ee2c49c..e49aabbb44b 100644 --- a/htdocs/core/lib/pdf.lib.php +++ b/htdocs/core/lib/pdf.lib.php @@ -1453,6 +1453,8 @@ function pdf_writelinedesc(&$pdf, $object, $i, $outputlangs, $w, $h, $posx, $pos } $parameters = array('pdf' => $pdf, 'i' => $i, 'outputlangs' => $outputlangs, 'w' => $w, 'h' => $h, 'posx' => $posx, 'posy' => $posy, 'hideref' => $hideref, 'hidedesc' => $hidedesc, 'issupplierline' => $issupplierline, 'special_code' => $special_code); $action = ''; + // WARNING: A hook must not close/open the PDF transaction. Doing this generates a lot of trouble. + // Test to know if content added by the hooks is already done by the main caller of pdf_writelinedesc $reshook = $hookmanager->executeHooks('pdf_writelinedesc', $parameters, $object, $action); // Note that $action and $object may have been modified by some hooks if (!empty($hookmanager->resPrint)) { From 35d6bc84099868c182b28cb5ee8e5874e158c2e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?= Date: Mon, 3 Mar 2025 14:40:30 +0100 Subject: [PATCH 21/32] add missing translation --- dev/translation/ignore_translation_keys.lst | 1 - htdocs/debugbar/class/DataCollector/DolExceptionsCollector.php | 2 ++ htdocs/langs/en_US/other.lang | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/dev/translation/ignore_translation_keys.lst b/dev/translation/ignore_translation_keys.lst index d4ae6fef13e..1c154e1ceb9 100644 --- a/dev/translation/ignore_translation_keys.lst +++ b/dev/translation/ignore_translation_keys.lst @@ -1003,7 +1003,6 @@ EmptyMessageNotAllowedError ErrorInputRequired ErrorLDAPFunctionsAreDisabledOnThisPHP ErrorUpdating -Exceptions Extra FailedToConnectToSFTPAfterSSHAuthentication FailedToLogin diff --git a/htdocs/debugbar/class/DataCollector/DolExceptionsCollector.php b/htdocs/debugbar/class/DataCollector/DolExceptionsCollector.php index 9e1313086f9..ca59c48f578 100644 --- a/htdocs/debugbar/class/DataCollector/DolExceptionsCollector.php +++ b/htdocs/debugbar/class/DataCollector/DolExceptionsCollector.php @@ -1,6 +1,7 @@ * Copyright (C) 2024 MDW + * Copyright (C) 2025 Frédéric France * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -39,6 +40,7 @@ class DolExceptionsCollector extends ExceptionsCollector { global $langs; + $langs->load("other"); $title = $langs->transnoentities('Exceptions'); return array( diff --git a/htdocs/langs/en_US/other.lang b/htdocs/langs/en_US/other.lang index 603fda6438f..560556751d0 100644 --- a/htdocs/langs/en_US/other.lang +++ b/htdocs/langs/en_US/other.lang @@ -356,3 +356,4 @@ Pre-Prompt=Pre-prompt Post-Prompt=Post-prompt AIProcessingPleaseWait=AI (%s) is processing your request, please wait... PayOfBankTransferInvoice=You are going to make an online payment for this invoice. However, this invoice has been set up to be paid in "Credit Transfer" mode, so to avoid paying twice, please verify that no current bank transfer has already been initiated before continuing. +Exceptions=Exceptions From ebe11cde5198ea06d8854bee97c62df09aa7eda2 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 14:42:15 +0100 Subject: [PATCH 22/32] Debug pdf (calculation of free text height) --- htdocs/core/lib/pdf.lib.php | 6 ++++-- htdocs/core/modules/facture/doc/pdf_crabe.modules.php | 4 ++-- htdocs/core/modules/facture/doc/pdf_sponge.modules.php | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/htdocs/core/lib/pdf.lib.php b/htdocs/core/lib/pdf.lib.php index e49aabbb44b..9f169a18462 100644 --- a/htdocs/core/lib/pdf.lib.php +++ b/htdocs/core/lib/pdf.lib.php @@ -339,6 +339,8 @@ function pdfGetHeightForHtmlContent(&$pdf, $htmlcontent) { // store current object $pdf->startTransaction(); + // To avoid pagebreak effect or strange behavior of writeHTMLCell when we are out of page, we imagine we are at the begin of page to test the height of the text + $pdf->setY(0); // store starting values $start_y = $pdf->GetY(); //var_dump($start_y); @@ -1212,7 +1214,7 @@ function pdf_pagefoot(&$pdf, $outputlangs, $paramfreetext, $fromcompany, $marge_ $pdf->SetDrawColor(224, 224, 224); // Option for footer text color if (getDolGlobalString('PDF_FOOTER_TEXT_COLOR')) { - list($r, $g, $b) = sscanf($conf->global->PDF_FOOTER_TEXT_COLOR, '%d, %d, %d'); + list($r, $g, $b) = sscanf(getDolGlobalString('PDF_FOOTER_TEXT_COLOR'), '%d, %d, %d'); $pdf->SetTextColor($r, $g, $b); } @@ -1231,7 +1233,7 @@ function pdf_pagefoot(&$pdf, $outputlangs, $paramfreetext, $fromcompany, $marge_ $freetextheight = $pdf->getStringHeight($width, $line); } else { $freetextheight = pdfGetHeightForHtmlContent($pdf, dol_htmlentitiesbr($line, 1, 'UTF-8', 0)); // New method (works for HTML content) - //print '
'.$freetextheight;exit; + //print '
'.$freetextheight; } } diff --git a/htdocs/core/modules/facture/doc/pdf_crabe.modules.php b/htdocs/core/modules/facture/doc/pdf_crabe.modules.php index a5c514576e1..8b4acc88d42 100644 --- a/htdocs/core/modules/facture/doc/pdf_crabe.modules.php +++ b/htdocs/core/modules/facture/doc/pdf_crabe.modules.php @@ -831,7 +831,7 @@ class pdf_crabe extends ModelePDFFactures } else { $this->_tableau($pdf, $tab_top_newpage, $this->page_hauteur - $tab_top_newpage - $heightforfooter, 0, $outputlangs, 1, 1, $object->multicurrency_code); } - $this->_pagefoot($pdf, $object, $outputlangs, 1, $this->getHeightForQRInvoice($pagenb, $object, $langs)); + $this->_pagefoot($pdf, $object, $outputlangs, 1, $this->getHeightForQRInvoice($pagenb, $object, $outputlangs)); $pagenb++; $pdf->setPage($pagenb); $pdf->setPageOrientation('', 1, 0); // The only function to edit the bottom margin of current page to set it. @@ -849,7 +849,7 @@ class pdf_crabe extends ModelePDFFactures } else { $this->_tableau($pdf, $tab_top_newpage, $this->page_hauteur - $tab_top_newpage - $heightforfooter, 0, $outputlangs, 1, 1, $object->multicurrency_code); } - $this->_pagefoot($pdf, $object, $outputlangs, 1, $this->getHeightForQRInvoice($pagenb, $object, $langs)); + $this->_pagefoot($pdf, $object, $outputlangs, 1, $this->getHeightForQRInvoice($pagenb, $object, $outputlangs)); // New page $pdf->AddPage(); if (!empty($tplidx)) { diff --git a/htdocs/core/modules/facture/doc/pdf_sponge.modules.php b/htdocs/core/modules/facture/doc/pdf_sponge.modules.php index f5457fc919d..9f39fb27975 100644 --- a/htdocs/core/modules/facture/doc/pdf_sponge.modules.php +++ b/htdocs/core/modules/facture/doc/pdf_sponge.modules.php @@ -343,7 +343,7 @@ class pdf_sponge extends ModelePDFFactures $this->heightforfreetext = getDolGlobalInt('MAIN_PDF_FREETEXT_HEIGHT', 5); // Height reserved to output the free text on last page $this->heightforfooter = $this->marge_basse + (!getDolGlobalString('MAIN_GENERATE_DOCUMENTS_SHOW_FOOT_DETAILS') ? 12 : 22); // Height reserved to output the footer (value include bottom margin) - $heightforqrinvoice = $heightforqrinvoice_firstpage = 0; + $heightforqrinvoice = 0; if (getDolGlobalString('INVOICE_ADD_SWISS_QR_CODE') == 'bottom') { if ($this->getHeightForQRInvoice(1, $object, $langs) > 0) { // Shrink infotot to a base 30 From 22ef2a018a80b3f58956a2c82c16b6cbb0bf1261 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 14:45:14 +0100 Subject: [PATCH 23/32] Doc --- htdocs/core/lib/pdf.lib.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/htdocs/core/lib/pdf.lib.php b/htdocs/core/lib/pdf.lib.php index 9f169a18462..3131f4e38ef 100644 --- a/htdocs/core/lib/pdf.lib.php +++ b/htdocs/core/lib/pdf.lib.php @@ -328,7 +328,8 @@ function pdf_getHeightForLogo($logo, $url = false) } /** - * Function to try to calculate height of a HTML Content + * Function to try to calculate height of a HTML Content. + * WARNING: Do not use this function inside a TCPDF transaction. * * @param TCPDF $pdf PDF initialized object * @param string $htmlcontent HTML Content @@ -340,6 +341,7 @@ function pdfGetHeightForHtmlContent(&$pdf, $htmlcontent) // store current object $pdf->startTransaction(); // To avoid pagebreak effect or strange behavior of writeHTMLCell when we are out of page, we imagine we are at the begin of page to test the height of the text + // Another solution would be to do the test on another PDF instance with samefont, width... $pdf->setY(0); // store starting values $start_y = $pdf->GetY(); From 284c2850e5b7a330d1a0cac219824b67e6258a70 Mon Sep 17 00:00:00 2001 From: Mohamed DAOUD Date: Mon, 3 Mar 2025 15:03:15 +0100 Subject: [PATCH 24/32] Fix cache directory check in getRemoteYamlFile method --- htdocs/admin/remotestore/class/externalModules.class.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/htdocs/admin/remotestore/class/externalModules.class.php b/htdocs/admin/remotestore/class/externalModules.class.php index 198ab07a1a0..cdb0362ca0a 100644 --- a/htdocs/admin/remotestore/class/externalModules.class.php +++ b/htdocs/admin/remotestore/class/externalModules.class.php @@ -641,10 +641,11 @@ class ExternalModules public function getRemoteYamlFile($file_source_url, $cache_time) { $cache_file = $this->cache_file; + $cache_folder = dirname($cache_file); // Check if cache directory exists - if (!dol_is_dir($cache_file)) { - dol_mkdir($cache_file, DOL_DATA_ROOT); + if (!dol_is_dir($cache_folder)) { + dol_mkdir($cache_folder, DOL_DATA_ROOT); } if (!file_exists($cache_file) || filemtime($cache_file) < (dol_now() - $cache_time)) { From 6d2de0a16fc96983bbeed57a3085e8be82cfc487 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 15:13:43 +0100 Subject: [PATCH 25/32] Fix remove $conf->global --- htdocs/core/class/html.formfile.class.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/htdocs/core/class/html.formfile.class.php b/htdocs/core/class/html.formfile.class.php index abb2d604b95..1d306a01143 100644 --- a/htdocs/core/class/html.formfile.class.php +++ b/htdocs/core/class/html.formfile.class.php @@ -969,10 +969,7 @@ class FormFile $out .= ''; - $documenturl = DOL_URL_ROOT.'/document.php'; - if (isset($conf->global->DOL_URL_ROOT_DOCUMENT_PHP)) { - $documenturl = getDolGlobalString('DOL_URL_ROOT_DOCUMENT_PHP'); // To use another wrapper - } + $documenturl = getDolGlobalString('DOL_URL_ROOT_DOCUMENT_PHP', DOL_URL_ROOT.'/document.php'); // DOL_URL_ROOT_DOCUMENT_PHP can be used to set another wrapper // Show file name with link to download $imgpreview = $this->showPreview($file, $modulepart, $relativepath, 0, $param); From 105ec63eafe86ae8a89685d9f1e3f57c4e9f1c5b Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 15:20:39 +0100 Subject: [PATCH 26/32] Debug v21 for multicompany --- htdocs/ecm/class/ecmfiles.class.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/ecm/class/ecmfiles.class.php b/htdocs/ecm/class/ecmfiles.class.php index 28db17eceb0..0bd44eceb31 100644 --- a/htdocs/ecm/class/ecmfiles.class.php +++ b/htdocs/ecm/class/ecmfiles.class.php @@ -1009,9 +1009,9 @@ class EcmFiles extends CommonObject if ($option) { if ($option == 'facture_fournisseur') { - $tmppath = preg_replace('/^fournisseur\/facture\//', '', $this->filepath); + $tmppath = preg_replace('/^(\d+\/)?fournisseur\/facture\//', '', $this->filepath); } elseif ($option == 'commande_fournisseur') { - $tmppath = preg_replace('/^fournisseur\/commande\//', '', $this->filepath); + $tmppath = preg_replace('/^(\d+\/)?fournisseur\/commande\//', '', $this->filepath); } else { if ((int) $this->entity > 1) { // Remove the part "entityid/commande/" into "entityid/commande/REFXXX" to get only the ref From 330d8d0d82661880eba2f7bda9cb970ad4965c88 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 15:52:07 +0100 Subject: [PATCH 27/32] Clean CSS file from no more existing class --- ChangeLog | 1 + htdocs/theme/eldy/global.inc.php | 3 --- htdocs/theme/md/style.css.php | 3 --- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index c17176bdf11..677172b0019 100644 --- a/ChangeLog +++ b/ChangeLog @@ -218,6 +218,7 @@ The following changes may create regressions for some external modules, but were * The trigger code CATEGORY_LINK and CATEGORY_UNLINK have been replaced with code CATEGORY_MODIFY. You can read ->context['linkto'] or ->context['unlinkoff'] to detect if we want to make a link or unlink. * The property ->domiciliation and ->propio on bank accounts has been deprecated and replaced with property ->address and ->owner_name everywhere. * If you were using the substitution key __MEMBER_CIVILITY__, you must now use __MEMBER_TITLE__ +* The hidden title of tab that was hidden by the CSS class tabTitleText has been completely removed from HTML content. ***** ChangeLog for 20.0.4 compared to 20.0.3 ***** diff --git a/htdocs/theme/eldy/global.inc.php b/htdocs/theme/eldy/global.inc.php index 7e597d769ba..50219ba0c3a 100644 --- a/htdocs/theme/eldy/global.inc.php +++ b/htdocs/theme/eldy/global.inc.php @@ -3991,9 +3991,6 @@ a.tabTitle { text-decoration: none; white-space: nowrap; } -.tabTitleText { - display: none; -} .imgTabTitle { max-height: 14px; } diff --git a/htdocs/theme/md/style.css.php b/htdocs/theme/md/style.css.php index 1da6838385a..e8ea2d48109 100644 --- a/htdocs/theme/md/style.css.php +++ b/htdocs/theme/md/style.css.php @@ -4138,9 +4138,6 @@ a.tabTitle { text-decoration: none; white-space: nowrap; } -.tabTitleText { - display: none; -} .imgTabTitle { max-height: 14px; } From a90f0863de1a619a67ca19c20ed4484f94ece834 Mon Sep 17 00:00:00 2001 From: Laurent Destailleur Date: Mon, 3 Mar 2025 16:33:03 +0100 Subject: [PATCH 28/32] Update company.php --- htdocs/admin/company.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/admin/company.php b/htdocs/admin/company.php index bdf19e2cfae..6188bd2802a 100644 --- a/htdocs/admin/company.php +++ b/htdocs/admin/company.php @@ -137,7 +137,7 @@ if (($action == 'update' && !GETPOST("cancel", 'alpha')) $arrayofimages = array('logo', 'logo_squarred'); //var_dump($_FILES); exit; foreach ($arrayofimages as $varforimage) { - if ($_FILES[$varforimage]["name"] && !image_format_supported($_FILES[$varforimage]["name"], 1)) { // Logo can be used on a lot of different places. Recommend using jpg and png for better compatibility. + if ($_FILES[$varforimage]["name"] && !image_format_supported($_FILES[$varforimage]["name"], 0)) { // Logo can be used on a lot of different places. Recommend using jpg and png for better compatibility. $langs->load("errors"); setEventMessages($langs->trans("ErrorBadImageFormat"), null, 'errors'); break; From b741ab4cfc40907aebcedbdb9863bcc8f973e3ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?= Date: Mon, 3 Mar 2025 16:39:27 +0100 Subject: [PATCH 29/32] remove duplicate --- htdocs/core/actions_sendmails.inc.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/htdocs/core/actions_sendmails.inc.php b/htdocs/core/actions_sendmails.inc.php index 744b212b287..6492494039c 100644 --- a/htdocs/core/actions_sendmails.inc.php +++ b/htdocs/core/actions_sendmails.inc.php @@ -1,6 +1,6 @@ - * Copyright (C) 2024 MDW + * Copyright (C) 2024 MDW * Copyright (C) 2024 Frédéric France * Copyright (C) 2013 Juanjo Menent * @@ -441,16 +441,13 @@ if (($action == 'send' || $action == 'relance') && !GETPOST('addfile') && !GETPO $object->email_to = $sendto; $object->email_tocc = $sendtocc; $object->email_tobcc = $sendtobcc; - $object->email_subject = $subject; // Call of triggers (you should have set $triggersendname to execute trigger. $trigger_name is deprecated) if (!empty($triggersendname) || !empty($trigger_name)) { - // Call trigger $result = $object->call_trigger(empty($triggersendname) ? $trigger_name : $triggersendname, $user); // @phan-suppress-current-line PhanPossiblyUndeclaredGlobalVariable if ($result < 0) { $error++; } - // End call triggers if ($error) { setEventMessages($object->error, $object->errors, 'errors'); } From 361ac7fa337575ffee9925a34177e222e1d81910 Mon Sep 17 00:00:00 2001 From: ldestailleur Date: Mon, 3 Mar 2025 16:49:34 +0100 Subject: [PATCH 30/32] Better sanitizing function --- htdocs/core/lib/functions.lib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php index 0e56d6a26d2..2921519e6c3 100644 --- a/htdocs/core/lib/functions.lib.php +++ b/htdocs/core/lib/functions.lib.php @@ -12566,7 +12566,7 @@ function dolGetBadge($label, $html = '', $type = 'primary', $mode = '', $url = ' // TODO: add hook // escape all attribute - $attr = array_map('dol_escape_htmltag', $attr); + $attr = array_map('dolPrintHtmlForAttribute', $attr); $TCompiledAttr = array(); foreach ($attr as $key => $value) { From 3bed970948a2a0ceee3adb6efe950fe5aedfeb03 Mon Sep 17 00:00:00 2001 From: EchoLoGeek <73399671+EchoLoGeek@users.noreply.github.com> Date: Mon, 3 Mar 2025 11:24:33 +0100 Subject: [PATCH 31/32] Remain to pay in multicurrency If I want to have the remainder to pay in foreign currency, I must deduct it from the amount in multicurrency, not the amount in conf->currency --- htdocs/core/class/commoninvoice.class.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/htdocs/core/class/commoninvoice.class.php b/htdocs/core/class/commoninvoice.class.php index 321533eb28d..cc759fa89af 100644 --- a/htdocs/core/class/commoninvoice.class.php +++ b/htdocs/core/class/commoninvoice.class.php @@ -286,7 +286,12 @@ abstract class CommonInvoice extends CommonObject $alreadypaid += $this->getSumDepositsUsed($multicurrency); $alreadypaid += $this->getSumCreditNotesUsed($multicurrency); - $remaintopay = price2num($this->total_ttc - $alreadypaid, 'MT'); + if((int) $multicurrency > 0){ + $totalamount = $this->multicurrency_total_ttc; + } else { + $totalamount = $this->total_ttc; + } + $remaintopay = price2num($totalamount - $alreadypaid, 'MT'); if ($this->status == self::STATUS_CLOSED && $this->close_code == 'discount_vat') { // If invoice closed with discount for anticipated payment $remaintopay = 0.0; } From 259f8f5643dd549851edf8768ad2bba2c69df791 Mon Sep 17 00:00:00 2001 From: EchoLoGeek <73399671+EchoLoGeek@users.noreply.github.com> Date: Mon, 3 Mar 2025 11:39:18 +0100 Subject: [PATCH 32/32] fix spaces --- htdocs/core/class/commoninvoice.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/core/class/commoninvoice.class.php b/htdocs/core/class/commoninvoice.class.php index cc759fa89af..ec4cf03f7df 100644 --- a/htdocs/core/class/commoninvoice.class.php +++ b/htdocs/core/class/commoninvoice.class.php @@ -286,7 +286,7 @@ abstract class CommonInvoice extends CommonObject $alreadypaid += $this->getSumDepositsUsed($multicurrency); $alreadypaid += $this->getSumCreditNotesUsed($multicurrency); - if((int) $multicurrency > 0){ + if ((int) $multicurrency > 0) { $totalamount = $this->multicurrency_total_ttc; } else { $totalamount = $this->total_ttc;