vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Qual: Rename $from as $from_line (filecheck_diff.php) (#39319)

Browse source 
# Qual: Rename $from as $from_line (filecheck_diff.php)

SqlInjectionPlugin is configured to consider that '$from' is an SQL expression
and requires that assignments to it are protected from Sql Injection.

Renaming '$from' fixes false positives.
This commit is contained in:
MDW 2026-07-30 17:05:49 +02:00 committed by GitHub
parent 273917d775
commit dd5df7d121
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
htdocs/blockedlog/admin/filecheck_diff.php
View file

@ -1,5 +1,6 @@
<?php
/* Copyright (C) 2026 Frédéric France <frederic.france@free.fr>
* Copyright (C) 2026 MDW <mdeweerd@users.noreply.github.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -263,9 +264,9 @@ function filecheckCollapseContext($diff, $context = 3)
$keep = array_fill(0, $n, false);
for ($i = 0; $i < $n; $i++) {
if ($diff[$i][0] !== ' ') {
$from = max(0, $i - $context);
$to = min($n - 1, $i + $context);
for ($k = $from; $k <= $to; $k++) {
$from_line = max(0, $i - $context);
$to_line = min($n - 1, $i + $context);
for ($k = $from_line; $k <= $to_line; $k++) {
$keep[$k] = true;
}
}
@ -385,7 +386,7 @@ llxFooterFragment();
/**
* Close the fragment output and stop the script.
*
* @return void
* @return never
*/
function llxFooterFragment()
{