Fix $mybool |=... which is binary op, not boolean op

# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
This commit is contained in:
MDW 2024-03-21 13:21:33 +01:00
parent 1e0f368d6a
commit d3a58e2e48
No known key found for this signature in database

View file

@ -200,17 +200,17 @@ class Fichinter extends CommonObject
/*
* Signed by sender
*/
CONST STATUS_SIGNED_SENDER = 1;
const STATUS_SIGNED_SENDER = 1;
/*
* Signed by receiver
*/
CONST STATUS_SIGNED_RECEIVER = 2;
const STATUS_SIGNED_RECEIVER = 2;
/*
* Signed by all
*/
CONST STATUS_SIGNED_ALL = 9; // To handle future kind of signature (ex: tripartite contract)
const STATUS_SIGNED_ALL = 9; // To handle future kind of signature (ex: tripartite contract)
/**
* Date delivery
@ -1010,7 +1010,7 @@ class Fichinter extends CommonObject
$dir = dol_buildpath($reldir."core/modules/fichinter/");
// Load file with numbering class (if found)
$mybool |= @include_once $dir.$file;
$mybool = ((bool) @include_once $dir.$file) || $mybool;
}
if ($mybool === false) {