From f2d80a2de83e9381bdcb8bb041a64d1e2a7474e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?= Date: Tue, 9 Jun 2026 11:37:22 +0200 Subject: [PATCH 1/3] avoid calling subtotals substitutions if not compatible (#38653) --- htdocs/subtotals/core/substitutions/functions_subtotals.lib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/subtotals/core/substitutions/functions_subtotals.lib.php b/htdocs/subtotals/core/substitutions/functions_subtotals.lib.php index 25505e2e9ca..b3b1cc35432 100644 --- a/htdocs/subtotals/core/substitutions/functions_subtotals.lib.php +++ b/htdocs/subtotals/core/substitutions/functions_subtotals.lib.php @@ -30,7 +30,7 @@ */ function subtotals_completesubstitutionarray_lines(&$substitutionarray, $langs, $object, $line) { - if (defined('SUBTOTALS_SPECIAL_CODE')) { + if (defined('SUBTOTALS_SPECIAL_CODE') && property_exists($object, 'ALLOWED_TYPES') && (in_array($object->element, $object::$ALLOWED_TYPES))) { $substitutionarray['is_subtotals_line'] = ($line->special_code == constant('SUBTOTALS_SPECIAL_CODE')); $substitutionarray['is_not_subtotals_line'] = !$substitutionarray['is_subtotals_line']; $substitutionarray['is_subtotals_title'] = (($line->special_code == constant('SUBTOTALS_SPECIAL_CODE')) && $line->qty > 0); From 66701737c2a7a11ccb15eee244446ab66f0a71ab Mon Sep 17 00:00:00 2001 From: Vincent Penel Date: Tue, 9 Jun 2026 11:43:15 +0200 Subject: [PATCH 2/3] Enforce status mode (#38620) * Enforce status mode * init var --- htdocs/ticket/class/ticket.class.php | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/htdocs/ticket/class/ticket.class.php b/htdocs/ticket/class/ticket.class.php index 77f3f9f13af..d2f8568e262 100644 --- a/htdocs/ticket/class/ticket.class.php +++ b/htdocs/ticket/class/ticket.class.php @@ -1513,7 +1513,9 @@ class Ticket extends CommonObject $labelStatus = (isset($status) && !empty($this->labelStatus[$status])) ? $this->labelStatus[$status] : ''; $labelStatusShort = (isset($status) && !empty($this->labelStatusShort[$status])) ? $this->labelStatusShort[$status] : ''; + $statusType = ''; + $isUnknown = false; switch ($status) { case self::STATUS_NOT_READ: // Not read $statusType = 'status0'; @@ -1540,10 +1542,8 @@ class Ticket extends CommonObject $statusType = 'status6'; break; default: - $labelStatus = 'Unknown'; - $labelStatusShort = 'Unknown'; - $statusType = 'status0'; - $mode = 0; + $isUnknown = true; + break; } $parameters = array( @@ -1558,6 +1558,13 @@ class Ticket extends CommonObject return $hookmanager->resPrint; } + if ($isUnknown) { + $labelStatus = 'Unknown'; + $labelStatusShort = 'Unknown'; + $statusType = 'status0'; + $mode = 0; + } + $params = array(); if ($notooltip) { $params = array('tooltip' => 'no'); From 049e2c5711ee983047d7c1b349413938bf465408 Mon Sep 17 00:00:00 2001 From: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com> Date: Tue, 9 Jun 2026 11:48:48 +0200 Subject: [PATCH 3/3] Add shipment online url to substitution array (#38654) * Add Shipment Online Url to substition array * Add Shipment Online Url to substitution array --- htdocs/core/lib/functions.lib.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php index 9d2cac4ec5a..97084dc0605 100644 --- a/htdocs/core/lib/functions.lib.php +++ b/htdocs/core/lib/functions.lib.php @@ -10818,6 +10818,10 @@ function getCommonSubstitutionArray($outputlangs, $onlykey = 0, $exclude = null, '@phan-var-force Expedition $object'; /** @var Expedition $object */ $substitutionarray['__URL_SHIPMENT__'] = DOL_MAIN_URL_ROOT . "/expedition/card.php?id=" . $object->id; + if (getDolGlobalInt('EXPEDITION_ALLOW_ONLINESIGN')) { + require_once DOL_DOCUMENT_ROOT . '/core/lib/signature.lib.php'; + $substitutionarray['__ONLINE_SIGN_URL__'] = getOnlineSignatureUrl(0, 'expedition', $object->ref, 1, $object); + } } }