vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

qual: phpstan for htdocs/salaries/class/paymentsalary.class.php (#28291)

Browse source 
* qual: phpstan for htdocs/salaries/class/paymentsalary.class.php

htdocs/salaries/class/paymentsalary.class.php	205	Property PaymentSalary::$amount (float) does not accept string.

htdocs/salaries/class/paymentsalary.class.php	292	Property PaymentSalary::$amount (float) does not accept string.

htdocs/salaries/class/paymentsalary.class.php	389	Property PaymentSalary::$amount (float) does not accept string.

htdocs/salaries/class/paymentsalary.class.php	565	Property PaymentSalary::$datec (int) does not accept string.

* Update paymentsalary.class.php - apply price2num() on $totalamount before testing if $totalamount==0

* typo
This commit is contained in:
thibdrev 2024-02-20 15:02:05 +01:00 committed by GitHub
parent 02e9ef8023
commit c67461bb38
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
htdocs/salaries/class/paymentsalary.class.php
View file

@ -202,7 +202,7 @@ class PaymentSalary extends CommonObject
$this->fk_salary = (int) $this->fk_salary;
}
if (isset($this->amount)) {
$this->amount = trim($this->amount);
$this->amount = (float) $this->amount;
}
if (isset($this->fk_typepayment)) {
$this->fk_typepayment = (int) $this->fk_typepayment;
@ -228,13 +228,13 @@ class PaymentSalary extends CommonObject
$totalamount = 0;
foreach ($this->amounts as $key => $value) { // How payment is dispatch
$newvalue = price2num($value, 'MT');
$newvalue = (float) price2num($value, 'MT');
$this->amounts[$key] = $newvalue;
$totalamount += $newvalue;
}
$totalamount = price2num($totalamount);
// Check parameters
$totalamount = (float) price2num($totalamount, 'MT'); // this is to ensure the following test is no biaised by a potential float equal to 0.0000000000001
if ($totalamount == 0) {
return -1;
} // On accepte les montants negatifs pour les rejets de prelevement mais pas null
@ -246,14 +246,13 @@ class PaymentSalary extends CommonObject
// Insert array of amounts
foreach ($this->amounts as $key => $amount) {
$salary_id = $key;
$amount = price2num($amount);
if (is_numeric($amount) && !empty($amount)) {
// We can have n payments for 1 salary but we can't have 1 payments for n salaries (for invoices link is n-n, not for salaries).
$sql = "INSERT INTO ".MAIN_DB_PREFIX."payment_salary (entity, fk_salary, datec, datep, amount,";
$sql .= " fk_typepayment, num_payment, note, fk_user_author, fk_bank)";
$sql .= " VALUES (".((int) $conf->entity).", ".((int) $salary_id).", '".$this->db->idate($now)."',";
$sql .= " '".$this->db->idate($this->datep)."',";
$sql .= " ".price2num($amount).",";
$sql .= " ".((float) $amount).",";
$sql .= " ".((int) $this->fk_typepayment).", '".$this->db->escape($this->num_payment)."', '".$this->db->escape($this->note)."', ".((int) $user->id).",";
$sql .= " 0)";
@ -386,7 +385,7 @@ class PaymentSalary extends CommonObject
$this->fk_salary = (int) $this->fk_salary;
}
if (isset($this->amount)) {
$this->amount = trim($this->amount);
$this->amount = (float) $this->amount;
}
if (isset($this->fk_typepayment)) {
$this->fk_typepayment = (int) $this->fk_typepayment;
@ -564,7 +563,7 @@ class PaymentSalary extends CommonObject
$this->fk_salary = 0;
$this->datec = '';
$this->tms = dol_now();
$this->datepaye = '';
$this->datepaye = dol_now();
$this->amount = 0.0;
$this->fk_typepayment = 0;
$this->num_payment = '';