Fix $mybool |=... which is binary op, not boolean op

# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
This commit is contained in:
MDW 2024-03-21 13:21:54 +01:00
parent 579f2dee4c
commit b3cda67e36
No known key found for this signature in database

View file

@ -1001,7 +1001,7 @@ class Skill extends CommonObject
$dir = dol_buildpath($reldir."core/modules/hrm/");
// Load file with numbering class (if found)
$mybool |= @include_once $dir.$file;
$mybool = ((bool) @include_once $dir.$file) || $mybool;
}
if ($mybool === false) {