vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

FIX - show correct shippable icon if order has multiple lines with same product (#37656)

Browse source 
In the current implementation it checks only line by line against the stock. This can lead to not correct show of shippable orders icon as this can be incorrect due to multiple lines with the same product.
Example: Stock of product A is 2. There are two lines with this product A. In the previous implementation it will check the first line against the stock 2-2=0 -> ok and then the same result for the next line but this is not correct as it doesn't reflect previous lines.
This commit is contained in:
splohmer 2026-03-30 20:06:24 +02:00 committed by GitHub
parent 7ecc96478a
commit adf9e3d270
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
htdocs/commande/list.php
View file

@ -3003,6 +3003,8 @@ while ($i < $imaxinloop) {
$generic_commande->getLinesArray(); // Load array ->lines
$generic_commande->loadExpeditions(); // Load array ->expeditions
$stock = [];
$numlines = count($generic_commande->lines); // Loop on each line of order
for ($lig = 0; $lig < $numlines; $lig++) {
$orderLine = $generic_commande->lines[$lig];
@ -3027,9 +3029,15 @@ while ($i < $imaxinloop) {
$generic_product->stock_theorique = $productstat_cachevirtual[$orderLine->fk_product]['stock_reel'];
}
if ($reliquat > $generic_product->stock_reel) {
if (!array_key_exists($orderLine->fk_product, $stock)) {
$stock[$orderLine->fk_product] = $generic_product->stock_reel;
}
if ($reliquat > $stock[$orderLine->fk_product]) {
$notshippable++;
}
$stock[$orderLine->fk_product] = $stock[$orderLine->fk_product] - $reliquat;
if (!getDolGlobalString('SHIPPABLE_ORDER_ICON_IN_LIST')) { // Default code. Default should be this case.
$text_info .= $reliquat.' x '.$orderLine->product_ref.'&nbsp;'.dol_trunc($orderLine->product_label, 20);
$text_info .= ' - '.$langs->trans("Stock").': <span class="'.($generic_product->stock_reel > 0 ? 'ok' : 'error').'">'.$generic_product->stock_reel.'</span>';