From 551eaa115cb32537a85b9db05d7de2aa7438dbe1 Mon Sep 17 00:00:00 2001 From: MDW Date: Fri, 15 Mar 2024 04:14:48 +0100 Subject: [PATCH] Fix & enable PhanPluginUnknownClosureReturnType # Fix & enable PhanPluginUnknownClosureReturnType Fix last PhanPluginUnknownClosureReturnType & enable the notice as all are fixed --- dev/tools/phan/config.php | 2 +- htdocs/variants/class/ProductCombination.class.php | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dev/tools/phan/config.php b/dev/tools/phan/config.php index 98c02fdc2d0..4570b839811 100644 --- a/dev/tools/phan/config.php +++ b/dev/tools/phan/config.php @@ -454,7 +454,7 @@ return [ // 'PhanPluginNoCommentOnProtectedProperty', // 'PhanPluginDescriptionlessCommentOnPublicMethod', // 'PhanPluginUnknownClosureParamType', - 'PhanPluginUnknownClosureReturnType', + // 'PhanPluginUnknownClosureReturnType', // 'PhanPluginNoCommentOnProtectedMethod', // 'PhanTypeArraySuspicious', // 'PhanTypeMismatchPropertyProbablyReal', diff --git a/htdocs/variants/class/ProductCombination.class.php b/htdocs/variants/class/ProductCombination.class.php index 7e183f75362..4e40c36a553 100644 --- a/htdocs/variants/class/ProductCombination.class.php +++ b/htdocs/variants/class/ProductCombination.class.php @@ -631,6 +631,7 @@ class ProductCombination $features, /** * @param mixed $v Feature information of a product. + * @return bool */ static function ($v) { return !empty($v);