From 88202d989f321c3d7bb50bf169f5f5976dcab6de Mon Sep 17 00:00:00 2001 From: MDW Date: Thu, 28 Mar 2024 01:48:30 +0100 Subject: [PATCH] Cast line->qty values to fix phan notices --- htdocs/bom/tpl/objectline_view.tpl.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/htdocs/bom/tpl/objectline_view.tpl.php b/htdocs/bom/tpl/objectline_view.tpl.php index cf6ca335125..6489f833759 100644 --- a/htdocs/bom/tpl/objectline_view.tpl.php +++ b/htdocs/bom/tpl/objectline_view.tpl.php @@ -196,7 +196,7 @@ $tmpbom->calculateCosts(); print ''; $coldisplay++; if (!empty($line->fk_bom_child)) { - echo ''.price($tmpbom->total_cost * $line->qty).''; + echo ''.price($tmpbom->total_cost * (float) $line->qty).''; } else { echo ''.price($line->total_cost).''; } @@ -303,7 +303,7 @@ if ($resql) { } print ''.$langs->trans('Yes').''; } else { - print ''.price($sub_bom_line->qty * $line->qty, 0, '', 0, 0).''; + print ''.price($sub_bom_line->qty * (float) $line->qty, 0, '', 0, 0).''; if (getDolGlobalString('PRODUCT_USE_UNITS')) { print ''; if ($label !== '') { @@ -328,8 +328,8 @@ if ($resql) { // Cost if (!empty($sub_bom->id)) { $sub_bom->calculateCosts(); - print ''.price(price2num($sub_bom->total_cost * $sub_bom_line->qty * $line->qty, 'MT')).''; - $total_cost += $sub_bom->total_cost * $sub_bom_line->qty * $line->qty; + print ''.price(price2num($sub_bom->total_cost * $sub_bom_line->qty * (float) $line->qty, 'MT')).''; + $total_cost += $sub_bom->total_cost * $sub_bom_line->qty * (float) $line->qty; } elseif ($sub_bom_product->type == Product::TYPE_SERVICE && isModEnabled('workstation') && !empty($sub_bom_product->fk_default_workstation)) { //Convert qty to hour $unit = measuringUnitString($sub_bom_line->fk_unit, '', '', 1); @@ -344,12 +344,12 @@ if ($resql) { $this->total_cost += $line->total_cost; } elseif ($sub_bom_product->cost_price > 0) { print ''; - print ''.price(price2num($sub_bom_product->cost_price * $sub_bom_line->qty * $line->qty, 'MT')).''; - $total_cost += $sub_bom_product->cost_price * $sub_bom_line->qty * $line->qty; + print ''.price(price2num($sub_bom_product->cost_price * $sub_bom_line->qty * (float) $line->qty, 'MT')).''; + $total_cost += $sub_bom_product->cost_price * $sub_bom_line->qty * (float) $line->qty; } elseif ($sub_bom_product->pmp > 0) { // PMP if cost price isn't defined print ''; - print ''.price(price2num($sub_bom_product->pmp * $sub_bom_line->qty * $line->qty, 'MT')).''; - $total_cost .= $sub_bom_product->pmp * $sub_bom_line->qty * $line->qty; + print ''.price(price2num($sub_bom_product->pmp * $sub_bom_line->qty * (float) $line->qty, 'MT')).''; + $total_cost .= $sub_bom_product->pmp * $sub_bom_line->qty * (float) $line->qty; } else { // Minimum purchase price if cost price and PMP aren't defined $sql_supplier_price = 'SELECT MIN(price) AS min_price, quantity AS qty FROM '.MAIN_DB_PREFIX.'product_fournisseur_price'; $sql_supplier_price .= ' WHERE fk_product = '. (int) $sub_bom_product->id; @@ -357,7 +357,7 @@ if ($resql) { if ($resql_supplier_price) { $obj = $object->db->fetch_object($resql_supplier_price); if (!empty($obj->qty) && !empty($sub_bom_line->qty) && !empty($line->qty)) { - $line_cost = $obj->min_price / $obj->qty * $sub_bom_line->qty * $line->qty; + $line_cost = $obj->min_price / $obj->qty * $sub_bom_line->qty * (float) $line->qty; } else { $line_cost = $obj->min_price; }