From 6f423170158b8091fe4f0addd9340e96751b24a0 Mon Sep 17 00:00:00 2001 From: thibdrev Date: Thu, 18 Jan 2024 17:38:46 +0100 Subject: [PATCH] fix: phpstan htdocs/variants/combinations.php 280 Property ProductCombination::$variation_weight (float) does not accept string. htdocs/variants/combinations.php 286 Property ProductCombination::$variation_price (float) does not accept string. htdocs/variants/combinations.php 292 Property ProductCombination::$variation_price (float) does not accept string. htdocs/variants/combinations.php 302 Property ProductCombinationLevel::$variation_price (float) does not accept string. --- htdocs/variants/combinations.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/htdocs/variants/combinations.php b/htdocs/variants/combinations.php index cad40bcf1e5..9f3dbf94a95 100644 --- a/htdocs/variants/combinations.php +++ b/htdocs/variants/combinations.php @@ -277,19 +277,19 @@ if (($action == 'add' || $action == 'create') && empty($massaction) && !GETPOST( exit(); } - $prodcomb->variation_weight = price2num($weight_impact); + $prodcomb->variation_weight = (float) price2num($weight_impact); // for conf PRODUIT_MULTIPRICES if (getDolGlobalString('PRODUIT_MULTIPRICES')) { $level_price_impact = array_map('price2num', $level_price_impact); - $prodcomb->variation_price = $level_price_impact[1]; + $prodcomb->variation_price = (float) $level_price_impact[1]; $prodcomb->variation_price_percentage = (bool) $level_price_impact_percent[1]; } else { $level_price_impact = array(1 => $price_impact); $level_price_impact_percent = array(1 => $price_impact_percent); - $prodcomb->variation_price = $price_impact; + $prodcomb->variation_price = (float) $price_impact; $prodcomb->variation_price_percentage = $price_impact_percent; } @@ -299,7 +299,7 @@ if (($action == 'add' || $action == 'create') && empty($massaction) && !GETPOST( $productCombinationLevel = new ProductCombinationLevel($db); $productCombinationLevel->fk_product_attribute_combination = $prodcomb->id; $productCombinationLevel->fk_price_level = $i; - $productCombinationLevel->variation_price = $level_price_impact[$i]; + $productCombinationLevel->variation_price = (float) $level_price_impact[$i]; $productCombinationLevel->variation_price_percentage = (bool) $level_price_impact_percent[$i]; $prodcomb->combination_price_levels[$i] = $productCombinationLevel; }