From 72f6422804303871824efa9f68065c0178b8dd67 Mon Sep 17 00:00:00 2001 From: MDW Date: Thu, 9 Oct 2025 18:18:49 +0200 Subject: [PATCH] Qual: Update baseline, fix new notice. (#35689) # Qual: Update baseline, fix new notice. Fix small new notice and update baseline with regards to other fixes. Co-authored-by: Laurent Destailleur --- dev/tools/phan/baseline.txt | 3 +-- htdocs/core/class/commoninvoice.class.php | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dev/tools/phan/baseline.txt b/dev/tools/phan/baseline.txt index 074c97342dc..08c4603f85e 100644 --- a/dev/tools/phan/baseline.txt +++ b/dev/tools/phan/baseline.txt @@ -12,7 +12,7 @@ return [ // PhanUndeclaredProperty : 420+ occurrences // PhanTypeMismatchProperty : 100+ occurrences // PhanTypeMismatchArgument : 70+ occurrences - // PhanUndeclaredGlobalVariable : 70+ occurrences + // PhanUndeclaredGlobalVariable : 65+ occurrences // PhanTypeMismatchArgumentNullable : 40+ occurrences // PhanTypeInvalidDimOffset : 15+ occurrences // PhanTypeMismatchDimFetch : 15+ occurrences @@ -230,7 +230,6 @@ return [ 'htdocs/projet/tasks.php' => ['PhanTypeMismatchArgument'], 'htdocs/projet/tasks/time.php' => ['PhanTypeInvalidDimOffset', 'PhanUndeclaredProperty'], 'htdocs/projet/tasks/tpl/linkedobjectblock.tpl.php' => ['PhanUndeclaredProperty'], - 'htdocs/public/eventorganization/subscriptionok.php' => ['PhanUndeclaredGlobalVariable'], 'htdocs/public/members/new.php' => ['PhanUndeclaredGlobalVariable'], 'htdocs/public/payment/newpayment.php' => ['PhanUndeclaredProperty'], 'htdocs/public/payment/paymentok.php' => ['PhanTypeMismatchArgumentProbablyReal'], diff --git a/htdocs/core/class/commoninvoice.class.php b/htdocs/core/class/commoninvoice.class.php index 992073021c2..7a692b81fa7 100644 --- a/htdocs/core/class/commoninvoice.class.php +++ b/htdocs/core/class/commoninvoice.class.php @@ -1062,7 +1062,7 @@ abstract class CommonInvoice extends CommonObject $statusdispute = $moreparams['dispute_status'] ? img_picto($langs->trans("DisputeOpen"), 'warning') : ''; } */ - if ($moreparams['dispute_status']) { + if (isset($moreparams['dispute_status']) && $moreparams['dispute_status']) { $labelStatus .= ' - '.$langs->trans("DisputeOpen"); $statusType = 'status8'; }