Fix #34720 do not crash on duplicate bank_url link for same target (#38916)

* Fix #36238 keep supplier filter when sorting product list

print_liste_field_titre signature is (name, file, field, begin, moreparam, ...)
but the seven calls in fourn/product/list.php passed $param at position 4
(begin) instead of 5 (moreparam), so the URL was rebuilt without the
fourn_id filter and the list reset when the user clicked a column header.
Swap to the correct slot, matching the fix already in the 22.0 line.

Signed-off-by: Dolicraft <contact@dolicraft.com>

* Fix #34720 do not crash on duplicate bank_url link for same target

llx_bank_url has a UNIQUE key on (fk_bank, url_id, type) so dispatching two
distinct credit transfers for the same employee on the same bank line raised a
Duplicate entry crash that left the operation in an unfinished state. Pre-check
the row and reuse the existing rowid silently, keeping the historical link
without breaking the calling transaction.

Signed-off-by: Dolicraft <contact@dolicraft.com>

---------

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
This commit is contained in:
w3houde 2026-06-27 18:28:39 +02:00 committed by GitHub
parent 429d3354e2
commit 60db2cbfe4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 7 deletions

View file

@ -463,6 +463,22 @@ class Account extends CommonObject
public function add_url_line($line_id, $url_id, $url, $label, $type)
{
// phpcs:enable
// Avoid uk_bank_url collision when the same target (line_id, url_id, type) is linked twice
// e.g. two distinct credit transfers for the same employee dispatched on the same bank line.
$sqlcheck = "SELECT rowid FROM ".MAIN_DB_PREFIX."bank_url";
$sqlcheck .= " WHERE fk_bank = ".((int) $line_id);
$sqlcheck .= " AND url_id = ".((int) $url_id);
$sqlcheck .= " AND type = '".$this->db->escape($type)."'";
$resqlcheck = $this->db->query($sqlcheck);
if ($resqlcheck) {
$obj = $this->db->fetch_object($resqlcheck);
if ($obj) {
$this->db->free($resqlcheck);
return (int) $obj->rowid;
}
$this->db->free($resqlcheck);
}
$sql = "INSERT INTO ".MAIN_DB_PREFIX."bank_url (";
$sql .= "fk_bank";
$sql .= ", url_id";

View file

@ -315,13 +315,13 @@ if ($resql) {
// Line for title
print '<tr class="liste_titre">';
print_liste_field_titre("Ref", $_SERVER["PHP_SELF"], "p.ref", $param, "", "", $sortfield, $sortorder);
print_liste_field_titre("RefSupplierShort", $_SERVER["PHP_SELF"], "ppf.ref_fourn", $param, "", "", $sortfield, $sortorder);
print_liste_field_titre("Label", $_SERVER["PHP_SELF"], "p.label", $param, "", "", $sortfield, $sortorder);
print_liste_field_titre("Supplier", $_SERVER["PHP_SELF"], "ppf.fk_soc", $param, "", "", $sortfield, $sortorder);
print_liste_field_titre("BuyingPrice", $_SERVER["PHP_SELF"], "ppf.price", $param, "", '', $sortfield, $sortorder, 'right ');
print_liste_field_titre("QtyMin", $_SERVER["PHP_SELF"], "ppf.quantity", $param, "", '', $sortfield, $sortorder, 'right ');
print_liste_field_titre("UnitPrice", $_SERVER["PHP_SELF"], "ppf.unitprice", $param, "", '', $sortfield, $sortorder, 'right ');
print_liste_field_titre("Ref", $_SERVER["PHP_SELF"], "p.ref", "", $param, "", $sortfield, $sortorder);
print_liste_field_titre("RefSupplierShort", $_SERVER["PHP_SELF"], "ppf.ref_fourn", "", $param, "", $sortfield, $sortorder);
print_liste_field_titre("Label", $_SERVER["PHP_SELF"], "p.label", "", $param, "", $sortfield, $sortorder);
print_liste_field_titre("Supplier", $_SERVER["PHP_SELF"], "ppf.fk_soc", "", $param, "", $sortfield, $sortorder);
print_liste_field_titre("BuyingPrice", $_SERVER["PHP_SELF"], "ppf.price", "", $param, '', $sortfield, $sortorder, 'right ');
print_liste_field_titre("QtyMin", $_SERVER["PHP_SELF"], "ppf.quantity", "", $param, '', $sortfield, $sortorder, 'right ');
print_liste_field_titre("UnitPrice", $_SERVER["PHP_SELF"], "ppf.unitprice", "", $param, '', $sortfield, $sortorder, 'right ');
// add header cells from hooks
$parameters = array();
$reshook = $hookmanager->executeHooks('printFieldListTitle', $parameters, $object, $action);