From 40a789f42e7fa0efcb9b8eedbfe014259f1f2b08 Mon Sep 17 00:00:00 2001 From: Pcauderlier Date: Tue, 9 Dec 2025 09:05:20 +0100 Subject: [PATCH 1/3] Fix: Use Societe->update() in ajaxstatusprospect.php to fire COMPANY_MODIFY trigger --- htdocs/core/ajax/ajaxstatusprospect.php | 28 ++++++++++++++++--------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/htdocs/core/ajax/ajaxstatusprospect.php b/htdocs/core/ajax/ajaxstatusprospect.php index cef9077144b..1b67f29f7f1 100644 --- a/htdocs/core/ajax/ajaxstatusprospect.php +++ b/htdocs/core/ajax/ajaxstatusprospect.php @@ -85,20 +85,28 @@ if ($action === "updatestatusprospect" && $permisstiontoupdate) { $prospectstatic->client = 2; $prospectstatic->loadCacheOfProspStatus(); - $response = ''; - $sql = "UPDATE ".MAIN_DB_PREFIX."societe SET "; - $sql .= "fk_stcomm = ".((int) $idstatus); - $sql .= " WHERE rowid = ".((int) $idprospect); + // Load thirdparty + $prospect = new Client($db); + $result = $prospect->fetch($idprospect); - $resql = $db->query($sql); + if ($result >= 0) { + $oldStatus = $prospect->fk_stcomm; - if (!$resql) { - dol_print_error($db); + // Apply new status + $prospect->fk_stcomm = $idstatus; + + // Update using business logic (fires COMPANY_MODIFY) + $updateResult = $prospect->update($prospect->id, $user); + + if ($updateResult >= 0) { + $response = img_action('', $prospectstatic->cacheprospectstatus[$idstatus]['code'], $prospectstatic->cacheprospectstatus[$idstatus]['picto'], 'class="inline-block valignmiddle paddingright pictoprospectstatus"'); + } else { + dol_syslog(__METHOD__.': Failed to update prospect via update() method', LOG_ERR); + dol_print_error($db); + } } else { - $num = $db->affected_rows($resql); - $response = img_action('', $prospectstatic->cacheprospectstatus[$idstatus]['code'], $prospectstatic->cacheprospectstatus[$idstatus]['picto'], 'class="inline-block valignmiddle paddingright pictoprospectstatus"'); + dol_print_error($db); } - echo json_encode(array('img' => $response)); } From 4bb5a0cdf13005c35974d57c3491b8e8097c3df5 Mon Sep 17 00:00:00 2001 From: Pcauderlier Date: Tue, 9 Dec 2025 09:30:42 +0100 Subject: [PATCH 2/3] Fix: Correct implementation of update() call in ajaxstatusprospect.php --- htdocs/core/ajax/ajaxstatusprospect.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/htdocs/core/ajax/ajaxstatusprospect.php b/htdocs/core/ajax/ajaxstatusprospect.php index 1b67f29f7f1..567cf17d8ad 100644 --- a/htdocs/core/ajax/ajaxstatusprospect.php +++ b/htdocs/core/ajax/ajaxstatusprospect.php @@ -87,14 +87,12 @@ if ($action === "updatestatusprospect" && $permisstiontoupdate) { // Load thirdparty - $prospect = new Client($db); + $prospect = new Societe($db); $result = $prospect->fetch($idprospect); if ($result >= 0) { - $oldStatus = $prospect->fk_stcomm; - // Apply new status - $prospect->fk_stcomm = $idstatus; + $prospect->stcomm_id = $idstatus; // Update using business logic (fires COMPANY_MODIFY) $updateResult = $prospect->update($prospect->id, $user); From 75bf0f7d1e4073f8804ec79de79f87cf2afd0ea6 Mon Sep 17 00:00:00 2001 From: Pcauderlier Date: Thu, 11 Dec 2025 09:02:15 +0100 Subject: [PATCH 3/3] FIX php-stan erros --- htdocs/core/ajax/ajaxstatusprospect.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/htdocs/core/ajax/ajaxstatusprospect.php b/htdocs/core/ajax/ajaxstatusprospect.php index 567cf17d8ad..a7ac677db3f 100644 --- a/htdocs/core/ajax/ajaxstatusprospect.php +++ b/htdocs/core/ajax/ajaxstatusprospect.php @@ -85,6 +85,7 @@ if ($action === "updatestatusprospect" && $permisstiontoupdate) { $prospectstatic->client = 2; $prospectstatic->loadCacheOfProspStatus(); + $response = ""; // Load thirdparty $prospect = new Societe($db); @@ -100,7 +101,7 @@ if ($action === "updatestatusprospect" && $permisstiontoupdate) { if ($updateResult >= 0) { $response = img_action('', $prospectstatic->cacheprospectstatus[$idstatus]['code'], $prospectstatic->cacheprospectstatus[$idstatus]['picto'], 'class="inline-block valignmiddle paddingright pictoprospectstatus"'); } else { - dol_syslog(__METHOD__.': Failed to update prospect via update() method', LOG_ERR); + dol_syslog('Failed to update prospect via update() method', LOG_ERR); dol_print_error($db); } } else {