diff --git a/htdocs/adherents/subscription.php b/htdocs/adherents/subscription.php index 03923f903a7..c2a5e9dc2d0 100644 --- a/htdocs/adherents/subscription.php +++ b/htdocs/adherents/subscription.php @@ -152,7 +152,7 @@ if (empty($reshook) && $action == 'confirm_create_thirdparty' && $confirm == 'ye } } -if (empty($reshook) && $action == 'setuserid' && ($user->rights->user->self->creer || $user->hasRight('user', 'user', 'creer'))) { +if (empty($reshook) && $action == 'setuserid' && ($user->hasRight('user', 'self', 'creer') || $user->hasRight('user', 'user', 'creer'))) { $error = 0; if (!$user->hasRight('user', 'user', 'creer')) { // If can edit only itself user, we can link to itself only if (GETPOST("userid", 'int') != $user->id && GETPOST("userid", 'int') != $object->user_id) { diff --git a/htdocs/admin/mails_templates.php b/htdocs/admin/mails_templates.php index 7788280a2ab..be327d58606 100644 --- a/htdocs/admin/mails_templates.php +++ b/htdocs/admin/mails_templates.php @@ -185,7 +185,7 @@ $elementList['user'] = img_picto('', 'user', 'class="pictofixedwidth"').dol_esca if (isModEnabled('adherent') && $user->hasRight('adherent', 'lire')) { $elementList['member'] = img_picto('', 'object_member', 'class="pictofixedwidth"').dol_escape_htmltag($langs->trans('MailToMember')); } -if (isModEnabled('recruitment') && !empty($user->rights->recruitment->recruitmentjobposition->read)) { +if (isModEnabled('recruitment') && $user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { $elementList['recruitmentcandidature_send'] = img_picto('', 'recruitmentcandidature', 'class="pictofixedwidth"').dol_escape_htmltag($langs->trans('RecruitmentCandidatures')); } if (isModEnabled("societe") && $user->hasRight('societe', 'lire')) { diff --git a/htdocs/categories/viewcat.php b/htdocs/categories/viewcat.php index 3a01c3b9c2d..6f75e34c088 100644 --- a/htdocs/categories/viewcat.php +++ b/htdocs/categories/viewcat.php @@ -911,7 +911,7 @@ if ($type == Categorie::TYPE_ACCOUNT) { if ($user->hasRight("banque", "read")) { require_once DOL_DOCUMENT_ROOT.'/compta/bank/class/account.class.php'; - $permission = $user->rights->banque->creer; + $permission = $user->hasRight('banque', 'creer'); $accounts = $object->getObjectsInCateg($type, 0, $limit, $offset); if ($accounts < 0) { @@ -1127,7 +1127,7 @@ if ($type == Categorie::TYPE_USER) { // Link to delete from category print ''; - if ($user->rights->user->user->creer) { + if ($user->hasRight('user', 'user', 'creer')) { print "id."'>"; print $langs->trans("DeleteFromCat"); print img_picto($langs->trans("DeleteFromCat"), 'unlink', '', false, 0, 0, '', 'paddingleft'); diff --git a/htdocs/compta/bank/bankentries_list.php b/htdocs/compta/bank/bankentries_list.php index ed601865f9e..90d336379d2 100644 --- a/htdocs/compta/bank/bankentries_list.php +++ b/htdocs/compta/bank/bankentries_list.php @@ -231,7 +231,7 @@ if (empty($reshook)) { $objectclass = 'Account'; $objectlabel = 'BankTransaction'; $permissiontoread = !empty($user->rights->banque->lire); - $permissiontodelete = !empty($user->rights->banque->modifier); + $permissiontodelete = $user->hasRight('banque', 'modifier'); $uploaddir = $conf->bank->dir_output; include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php'; } @@ -328,7 +328,7 @@ if ((GETPOST('confirm_savestatement', 'alpha') || GETPOST('confirm_reconcile', ' } -if (GETPOST('save') && !$cancel && !empty($user->rights->banque->modifier)) { +if (GETPOST('save') && !$cancel && $user->hasRight('banque', 'modifier')) { $error = 0; if (price2num(GETPOST("addcredit")) > 0) { @@ -388,7 +388,7 @@ if (GETPOST('save') && !$cancel && !empty($user->rights->banque->modifier)) { } } -if ($action == 'confirm_delete' && $confirm == 'yes' && !empty($user->rights->banque->modifier)) { +if ($action == 'confirm_delete' && $confirm == 'yes' && $user->hasRight('banque', 'modifier')) { $accline = new AccountLine($db); $result = $accline->fetch(GETPOST("rowid", "int")); $result = $accline->delete($user); @@ -885,7 +885,7 @@ if ($resql) { } // Form to add a transaction with no invoice - if (!empty($user->rights->banque->modifier) && $action == 'addline' && !empty($conf->global->BANK_USE_OLD_VARIOUS_PAYMENT)) { + if ($user->hasRight('banque', 'modifier') && $action == 'addline' && !empty($conf->global->BANK_USE_OLD_VARIOUS_PAYMENT)) { print load_fiche_titre($langs->trans("AddBankRecordLong"), '', ''); print ''; diff --git a/htdocs/core/boxes/box_accountancy_last_manual_entries.php b/htdocs/core/boxes/box_accountancy_last_manual_entries.php index 7cdb220653a..54a1dd0cb63 100644 --- a/htdocs/core/boxes/box_accountancy_last_manual_entries.php +++ b/htdocs/core/boxes/box_accountancy_last_manual_entries.php @@ -60,7 +60,7 @@ class box_accountancy_last_manual_entries extends ModeleBoxes $this->db = $db; - $this->hidden = empty($user->rights->accounting->mouvements->lire); + $this->hidden = !$user->hasRight('accounting', 'mouvements', 'lire'); } /** diff --git a/htdocs/core/boxes/box_accountancy_suspense_account.php b/htdocs/core/boxes/box_accountancy_suspense_account.php index 74a46e3f241..0a6fa06033f 100644 --- a/htdocs/core/boxes/box_accountancy_suspense_account.php +++ b/htdocs/core/boxes/box_accountancy_suspense_account.php @@ -60,7 +60,7 @@ class box_accountancy_suspense_account extends ModeleBoxes $this->db = $db; - $this->hidden = empty($user->rights->accounting->mouvements->lire); + $this->hidden = !$user->hasRight('accounting', 'mouvements', 'lire'); } /** diff --git a/htdocs/core/class/utils.class.php b/htdocs/core/class/utils.class.php index f67702ca7c9..3f1fe9ff888 100644 --- a/htdocs/core/class/utils.class.php +++ b/htdocs/core/class/utils.class.php @@ -186,7 +186,7 @@ class Utils } // Recreate temp dir that are not automatically recreated by core code for performance purpose, we need them - if (!empty($conf->api->enabled)) { + if (isModEnabled('api')) { dol_mkdir($conf->api->dir_temp); } dol_mkdir($conf->user->dir_temp); diff --git a/htdocs/core/lib/files.lib.php b/htdocs/core/lib/files.lib.php index 820e84f7f66..6320a82dfa5 100644 --- a/htdocs/core/lib/files.lib.php +++ b/htdocs/core/lib/files.lib.php @@ -3150,7 +3150,7 @@ function dol_check_secure_access_document($modulepart, $original_file, $entity, $original_file = $conf->import->dir_temp.'/'.$original_file; } elseif ($modulepart == 'recruitment' && !empty($conf->recruitment->dir_output)) { // Wrapping for recruitment module - $accessallowed = $user->rights->recruitment->recruitmentjobposition->read; + $accessallowed = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); $original_file = $conf->recruitment->dir_output.'/'.$original_file; } elseif ($modulepart == 'editor' && !empty($conf->fckeditor->dir_output)) { // Wrapping for wysiwyg editor diff --git a/htdocs/core/lib/security.lib.php b/htdocs/core/lib/security.lib.php index fe1343e5b9e..382e562b162 100644 --- a/htdocs/core/lib/security.lib.php +++ b/htdocs/core/lib/security.lib.php @@ -595,7 +595,7 @@ function restrictedArea(User $user, $features, $object = 0, $tableandshare = '', $nbko++; } } elseif ($feature == 'banque') { - if (empty($user->rights->banque->modifier)) { + if (!$user->hasRight('banque', 'modifier')) { $createok = 0; $nbko++; } @@ -666,7 +666,7 @@ function restrictedArea(User $user, $features, $object = 0, $tableandshare = '', // Check create user permission $createuserok = 1; if (GETPOST('action', 'aZ09') == 'confirm_create_user' && GETPOST("confirm", 'aZ09') == 'yes') { - if (!$user->rights->user->user->creer) { + if (!$user->hasRight('user', 'user', 'creer')) { $createuserok = 0; } @@ -716,7 +716,7 @@ function restrictedArea(User $user, $features, $object = 0, $tableandshare = '', $deleteok = 0; } } elseif ($feature == 'banque') { - if (empty($user->rights->banque->modifier)) { + if (!$user->hasRight('banque', 'modifier')) { $deleteok = 0; } } elseif ($feature == 'cheque') { diff --git a/htdocs/core/modules/modRecruitment.class.php b/htdocs/core/modules/modRecruitment.class.php index 499b6419982..c33c9a5daa6 100644 --- a/htdocs/core/modules/modRecruitment.class.php +++ b/htdocs/core/modules/modRecruitment.class.php @@ -265,7 +265,7 @@ class modRecruitment extends DolibarrModules 'langs'=>'recruitment', // Lang file to use (without .lang) by module. File must be in langs/code_CODE/ directory. 'position'=>1000 + $r, 'enabled'=>'$conf->recruitment->enabled', // Define condition to show or hide menu entry. Use '$conf->recruitment->enabled' if entry must be visible if module is enabled. - 'perms'=>'$user->rights->recruitment->recruitmentjobposition->read', // Use 'perms'=>'$user->rights->recruitment->level1->level2' if you want your menu with a permission rules + 'perms'=>'$user->hasRight("recruitment", "recruitmentjobposition", "read")', // Use 'perms'=>'$user->rights->recruitment->level1->level2' if you want your menu with a permission rules 'target'=>'', 'user'=>2, // 0=Menu for internal users, 1=external users, 2=both ); @@ -293,7 +293,7 @@ class modRecruitment extends DolibarrModules 'langs'=>'recruitment', // Lang file to use (without .lang) by module. File must be in langs/code_CODE/ directory. 'position'=>1000 + $r, 'enabled'=>'$conf->recruitment->enabled', // Define condition to show or hide menu entry. Use '$conf->recruitment->enabled' if entry must be visible if module is enabled. Use '$leftmenu==\'system\'' to show if leftmenu system is selected. - 'perms'=>'$user->rights->recruitment->recruitmentjobposition->read', // Use 'perms'=>'$user->rights->recruitment->level1->level2' if you want your menu with a permission rules + 'perms'=>'$user->hasRight("recruitment", "recruitmentjobposition", "read")', // Use 'perms'=>'$user->rights->recruitment->level1->level2' if you want your menu with a permission rules 'target'=>'', 'user'=>2, // 0=Menu for internal users, 1=external users, 2=both ); @@ -321,7 +321,7 @@ class modRecruitment extends DolibarrModules 'langs'=>'recruitment', // Lang file to use (without .lang) by module. File must be in langs/code_CODE/ directory. 'position'=>1000 + $r, 'enabled'=>'$conf->recruitment->enabled', // Define condition to show or hide menu entry. Use '$conf->recruitment->enabled' if entry must be visible if module is enabled. Use '$leftmenu==\'system\'' to show if leftmenu system is selected. - 'perms'=>'$user->rights->recruitment->recruitmentjobposition->read', // Use 'perms'=>'$user->rights->recruitment->level1->level2' if you want your menu with a permission rules + 'perms'=>'$user->hasRight("recruitment", "recruitmentjobposition", "read")', // Use 'perms'=>'$user->rights->recruitment->level1->level2' if you want your menu with a permission rules 'target'=>'', 'user'=>2, // 0=Menu for internal users, 1=external users, 2=both ); diff --git a/htdocs/expensereport/list.php b/htdocs/expensereport/list.php index bb188c3fafc..da22037e771 100644 --- a/htdocs/expensereport/list.php +++ b/htdocs/expensereport/list.php @@ -176,7 +176,7 @@ $arrayfields = array( // Extra fields include DOL_DOCUMENT_ROOT.'/core/tpl/extrafields_list_array_fields.tpl.php'; -$canedituser = (!empty($user->admin) || $user->rights->user->user->creer); +$canedituser = (!empty($user->admin) || $user->hasRight('user', 'user', 'creer')); $objectuser = new User($db); diff --git a/htdocs/recruitment/class/api_recruitment.class.php b/htdocs/recruitment/class/api_recruitment.class.php index bcce3d9b92c..7b34a6abc31 100644 --- a/htdocs/recruitment/class/api_recruitment.class.php +++ b/htdocs/recruitment/class/api_recruitment.class.php @@ -76,7 +76,7 @@ class Recruitment extends DolibarrApi */ public function getJobPosition($id) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->read) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { throw new RestException(401); } @@ -107,7 +107,7 @@ class Recruitment extends DolibarrApi */ public function getCandidature($id) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->read) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { throw new RestException(401); } @@ -147,7 +147,7 @@ class Recruitment extends DolibarrApi $obj_ret = array(); $tmpobject = new RecruitmentJobPosition($this->db); - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->read) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { throw new RestException(401); } @@ -254,7 +254,7 @@ class Recruitment extends DolibarrApi $obj_ret = array(); $tmpobject = new RecruitmentCandidature($this->db); - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->read) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { throw new RestException(401); } @@ -350,7 +350,7 @@ class Recruitment extends DolibarrApi */ public function postJobPosition($request_data = null) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->write) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'write')) { throw new RestException(401); } @@ -382,7 +382,7 @@ class Recruitment extends DolibarrApi */ public function postCandidature($request_data = null) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->write) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'write')) { throw new RestException(401); } @@ -415,7 +415,7 @@ class Recruitment extends DolibarrApi */ public function putJobPosition($id, $request_data = null) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->write) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'write')) { throw new RestException(401); } @@ -458,7 +458,7 @@ class Recruitment extends DolibarrApi */ public function putCandidature($id, $request_data = null) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->write) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'write')) { throw new RestException(401); } @@ -501,7 +501,7 @@ class Recruitment extends DolibarrApi */ public function deleteJobPosition($id) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->delete) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'delete')) { throw new RestException(401); } $result = $this->jobposition->fetch($id); @@ -537,7 +537,7 @@ class Recruitment extends DolibarrApi */ public function deleteCandidature($id) { - if (!DolibarrApiAccess::$user->rights->recruitment->recruitmentjobposition->delete) { + if (!DolibarrApiAccess::$user->hasRight('recruitment', 'recruitmentjobposition', 'delete')) { throw new RestException(401); } $result = $this->candidature->fetch($id); diff --git a/htdocs/recruitment/class/recruitmentjobposition.class.php b/htdocs/recruitment/class/recruitmentjobposition.class.php index f4301837ef2..a786c0196bb 100644 --- a/htdocs/recruitment/class/recruitmentjobposition.class.php +++ b/htdocs/recruitment/class/recruitmentjobposition.class.php @@ -202,7 +202,7 @@ class RecruitmentJobPosition extends CommonObject } // Example to show how to set values of fields definition dynamically - /*if ($user->rights->recruitment->recruitmentjobposition->read) { + /*if ($user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { $this->fields['myfield']['visible'] = 1; $this->fields['myfield']['noteditable'] = 0; }*/ diff --git a/htdocs/recruitment/index.php b/htdocs/recruitment/index.php index 03b2a9e6431..2cab6f25053 100644 --- a/htdocs/recruitment/index.php +++ b/htdocs/recruitment/index.php @@ -333,7 +333,7 @@ $NBMAX = $conf->global->MAIN_SIZE_SHORTLIST_LIMIT; $max = $conf->global->MAIN_SIZE_SHORTLIST_LIMIT; // Last modified job position -if (isModEnabled('recruitment') && $user->rights->recruitment->recruitmentjobposition->read) { +if (isModEnabled('recruitment') && $user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { $sql = "SELECT s.rowid, s.ref, s.label, s.date_creation, s.tms, s.status, COUNT(rc.rowid) as nbapplications"; $sql .= " FROM ".MAIN_DB_PREFIX."recruitment_recruitmentjobposition as s"; $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."recruitment_recruitmentcandidature as rc ON rc.fk_recruitmentjobposition = s.rowid"; @@ -404,7 +404,7 @@ if (isModEnabled('recruitment') && $user->rights->recruitment->recruitmentjobpos } // Last modified job position -if (isModEnabled('recruitment') && $user->rights->recruitment->recruitmentjobposition->read) { +if (isModEnabled('recruitment') && $user->hasRight('recruitment', 'recruitmentjobposition', 'read')) { $sql = "SELECT rc.rowid, rc.ref, rc.email, rc.lastname, rc.firstname, rc.date_creation, rc.tms, rc.status"; $sql .= " FROM ".MAIN_DB_PREFIX."recruitment_recruitmentcandidature as rc"; $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."recruitment_recruitmentjobposition as s ON rc.fk_recruitmentjobposition = s.rowid"; diff --git a/htdocs/recruitment/recruitmentcandidature_agenda.php b/htdocs/recruitment/recruitmentcandidature_agenda.php index 757c9ac19d5..410e6091e6a 100644 --- a/htdocs/recruitment/recruitmentcandidature_agenda.php +++ b/htdocs/recruitment/recruitmentcandidature_agenda.php @@ -85,7 +85,7 @@ if ($id > 0 || !empty($ref)) { $upload_dir = $conf->recruitment->multidir_output[!empty($object->entity) ? $object->entity : $conf->entity]."/".$object->id; } -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php // Security check - Protection if external user //if ($user->socid > 0) accessforbidden(); diff --git a/htdocs/recruitment/recruitmentcandidature_card.php b/htdocs/recruitment/recruitmentcandidature_card.php index 5a6f8a58443..9494c9d59cd 100644 --- a/htdocs/recruitment/recruitmentcandidature_card.php +++ b/htdocs/recruitment/recruitmentcandidature_card.php @@ -73,11 +73,11 @@ if (empty($action) && empty($id) && empty($ref)) { include DOL_DOCUMENT_ROOT.'/core/actions_fetchobject.inc.php'; // Must be include, not include_once. -$permissiontoread = $user->rights->recruitment->recruitmentjobposition->read; -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php and actions_lineupdown.inc.php -$permissiontodelete = $user->rights->recruitment->recruitmentjobposition->delete || ($permissiontoadd && isset($object->status) && $object->status == $object::STATUS_DRAFT); -$permissionnote = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_setnotes.inc.php -$permissiondellink = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_dellink.inc.php +$permissiontoread = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_lineupdown.inc.php +$permissiontodelete = $user->hasRight('recruitment', 'recruitmentjobposition', 'delete') || ($permissiontoadd && isset($object->status) && $object->status == $object::STATUS_DRAFT); +$permissionnote = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_setnotes.inc.php +$permissiondellink = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_dellink.inc.php $upload_dir = $conf->recruitment->multidir_output[isset($object->entity) ? $object->entity : 1]; // Security check - Protection if external user @@ -579,7 +579,7 @@ if ($object->id > 0 && (empty($action) || ($action != 'edit' && $action != 'crea // Button to convert into a user if ($object->status == $object::STATUS_CONTRACT_SIGNED) { - if ($user->rights->user->user->creer) { + if ($user->hasRight('user', 'user', 'creer')) { $useralreadyexists = $object->fk_user; if (empty($useralreadyexists)) { print '
'.$langs->trans("CreateDolibarrLogin").'
'; @@ -624,8 +624,8 @@ if ($object->id > 0 && (empty($action) || ($action != 'edit' && $action != 'crea $relativepath = $objref.'/'.$objref.'.pdf'; $filedir = $conf->recruitment->dir_output.'/'.$object->element.'/'.$objref; $urlsource = $_SERVER["PHP_SELF"]."?id=".$object->id; - $genallowed = $user->rights->recruitment->recruitmentjobposition->read; // If you can read, you can build the PDF to read content - $delallowed = $user->rights->recruitment->recruitmentjobposition->write; // If you can create/edit, you can remove a file on card + $genallowed = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); // If you can read, you can build the PDF to read content + $delallowed = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // If you can create/edit, you can remove a file on card print $formfile->showdocuments('recruitment:RecruitmentCandidature', $object->element.'/'.$objref, $filedir, $urlsource, $genallowed, $delallowed, $object->model_pdf, 1, 0, 0, 28, 0, '', '', '', $langs->defaultlang); } diff --git a/htdocs/recruitment/recruitmentcandidature_document.php b/htdocs/recruitment/recruitmentcandidature_document.php index 4517eeabd04..caa4ad2d619 100644 --- a/htdocs/recruitment/recruitmentcandidature_document.php +++ b/htdocs/recruitment/recruitmentcandidature_document.php @@ -80,7 +80,7 @@ if ($id > 0 || !empty($ref)) { $isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0); $result = restrictedArea($user, 'recruitment', $object->id, 'recruitment_recruitmentcandidature', 'recruitmentjobposition', '', 'rowid', $isdraft); -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php @@ -182,8 +182,8 @@ if ($object->id) { print dol_get_fiche_end(); $modulepart = 'recruitment'; - $permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; - $permtoedit = $user->rights->recruitment->recruitmentjobposition->write; + $permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); + $permtoedit = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); $param = '&id='.$object->id; $relativepathwithnofile = 'recruitmentcandidature/'.dol_sanitizeFileName($object->ref).'/'; diff --git a/htdocs/recruitment/recruitmentcandidature_list.php b/htdocs/recruitment/recruitmentcandidature_list.php index 77577627dce..cc3a29e5475 100644 --- a/htdocs/recruitment/recruitmentcandidature_list.php +++ b/htdocs/recruitment/recruitmentcandidature_list.php @@ -138,9 +138,9 @@ if ($id > 0 || !empty($ref)) { $object->fields = dol_sort_array($object->fields, 'position'); $arrayfields = dol_sort_array($arrayfields, 'position'); -$permissiontoread = $user->rights->recruitment->recruitmentjobposition->read; -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; -$permissiontodelete = $user->rights->recruitment->recruitmentjobposition->delete; +$permissiontoread = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); +$permissiontodelete = $user->hasRight('recruitment', 'recruitmentjobposition', 'delete'); // Security check - Protection if external user //if ($user->socid > 0) accessforbidden(); diff --git a/htdocs/recruitment/recruitmentcandidature_note.php b/htdocs/recruitment/recruitmentcandidature_note.php index 931f7d0627a..a7af0fac525 100644 --- a/htdocs/recruitment/recruitmentcandidature_note.php +++ b/htdocs/recruitment/recruitmentcandidature_note.php @@ -51,8 +51,8 @@ if ($id > 0 || !empty($ref)) { $upload_dir = $conf->recruitment->multidir_output[!empty($object->entity) ? $object->entity : $conf->entity]."/".$object->id; } -$permissionnote = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_setnotes.inc.php -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php +$permissionnote = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_setnotes.inc.php +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php // Security check - Protection if external user //if ($user->socid > 0) accessforbidden(); diff --git a/htdocs/recruitment/recruitmentjobposition_agenda.php b/htdocs/recruitment/recruitmentjobposition_agenda.php index fca34f5b141..96aa1f27021 100644 --- a/htdocs/recruitment/recruitmentjobposition_agenda.php +++ b/htdocs/recruitment/recruitmentjobposition_agenda.php @@ -84,7 +84,7 @@ if ($id > 0 || !empty($ref)) { $upload_dir = $conf->recruitment->multidir_output[!empty($object->entity) ? $object->entity : $conf->entity]."/".$object->id; } -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php // Security check - Protection if external user //if ($user->socid > 0) accessforbidden(); diff --git a/htdocs/recruitment/recruitmentjobposition_applications.php b/htdocs/recruitment/recruitmentjobposition_applications.php index 76250a20b8d..454bbee2033 100644 --- a/htdocs/recruitment/recruitmentjobposition_applications.php +++ b/htdocs/recruitment/recruitmentjobposition_applications.php @@ -72,11 +72,11 @@ if (empty($action) && empty($id) && empty($ref)) { include DOL_DOCUMENT_ROOT.'/core/actions_fetchobject.inc.php'; // Must be include, not include_once. -$permissiontoread = $user->rights->recruitment->recruitmentjobposition->read; -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php and actions_lineupdown.inc.php -$permissiontodelete = $user->rights->recruitment->recruitmentjobposition->delete || ($permissiontoadd && isset($object->status) && $object->status == $object::STATUS_DRAFT); -$permissionnote = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_setnotes.inc.php -$permissiondellink = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_dellink.inc.php +$permissiontoread = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_lineupdown.inc.php +$permissiontodelete = $user->hasRight('recruitment', 'recruitmentjobposition', 'delete') || ($permissiontoadd && isset($object->status) && $object->status == $object::STATUS_DRAFT); +$permissionnote = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_setnotes.inc.php +$permissiondellink = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_dellink.inc.php $upload_dir = $conf->recruitment->multidir_output[isset($object->entity) ? $object->entity : 1]; // Security check - Protection if external user diff --git a/htdocs/recruitment/recruitmentjobposition_card.php b/htdocs/recruitment/recruitmentjobposition_card.php index 9b47b7fe71d..b8a9a5ccd8d 100644 --- a/htdocs/recruitment/recruitmentjobposition_card.php +++ b/htdocs/recruitment/recruitmentjobposition_card.php @@ -72,11 +72,11 @@ if (empty($action) && empty($id) && empty($ref)) { include DOL_DOCUMENT_ROOT.'/core/actions_fetchobject.inc.php'; // Must be include, not include_once. -$permissiontoread = $user->rights->recruitment->recruitmentjobposition->read; -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php and actions_lineupdown.inc.php -$permissiontodelete = $user->rights->recruitment->recruitmentjobposition->delete || ($permissiontoadd && isset($object->status) && $object->status == $object::STATUS_DRAFT); -$permissionnote = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_setnotes.inc.php -$permissiondellink = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_dellink.inc.php +$permissiontoread = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_lineupdown.inc.php +$permissiontodelete = $user->hasRight('recruitment', 'recruitmentjobposition', 'delete') || ($permissiontoadd && isset($object->status) && $object->status == $object::STATUS_DRAFT); +$permissionnote = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_setnotes.inc.php +$permissiondellink = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_dellink.inc.php $upload_dir = $conf->recruitment->multidir_output[isset($object->entity) ? $object->entity : 1]; $usercanclose = $permissiontoadd; @@ -473,8 +473,8 @@ if ($object->id > 0 && (empty($action) || ($action != 'edit' && $action != 'crea $relativepath = $objref.'/'.$objref.'.pdf'; $filedir = $conf->recruitment->dir_output.'/'.$object->element.'/'.$objref; $urlsource = $_SERVER["PHP_SELF"]."?id=".$object->id; - $genallowed = $user->rights->recruitment->recruitmentjobposition->read; // If you can read, you can build the PDF to read content - $delallowed = $user->rights->recruitment->recruitmentjobposition->write; // If you can create/edit, you can remove a file on card + $genallowed = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); // If you can read, you can build the PDF to read content + $delallowed = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // If you can create/edit, you can remove a file on card print $formfile->showdocuments('recruitment:RecruitmentJobPosition', $object->element.'/'.$objref, $filedir, $urlsource, $genallowed, $delallowed, $object->model_pdf, 1, 0, 0, 28, 0, '', '', '', $langs->defaultlang); } diff --git a/htdocs/recruitment/recruitmentjobposition_document.php b/htdocs/recruitment/recruitmentjobposition_document.php index aa8630f7108..37b107ce670 100644 --- a/htdocs/recruitment/recruitmentjobposition_document.php +++ b/htdocs/recruitment/recruitmentjobposition_document.php @@ -80,7 +80,7 @@ if ($id > 0 || !empty($ref)) { $isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0); $result = restrictedArea($user, 'recruitment', $object->id, 'recruitment_recruitmentjobposition', 'recruitmentjobposition', '', 'rowid', $isdraft); -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php @@ -182,8 +182,8 @@ if ($object->id) { print dol_get_fiche_end(); $modulepart = 'recruitment'; - $permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; - $permtoedit = $user->rights->recruitment->recruitmentjobposition->write; + $permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); + $permtoedit = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); $param = '&id='.$object->id; $relativepathwithnofile = 'recruitmentjobposition/'.dol_sanitizeFileName($object->ref).'/'; diff --git a/htdocs/recruitment/recruitmentjobposition_list.php b/htdocs/recruitment/recruitmentjobposition_list.php index 5a759250ae6..db7e6db5c29 100644 --- a/htdocs/recruitment/recruitmentjobposition_list.php +++ b/htdocs/recruitment/recruitmentjobposition_list.php @@ -124,9 +124,9 @@ $object->fields = dol_sort_array($object->fields, 'position'); $arrayfields['nbapplications'] = array('type'=>'integer', 'label'=>'Applications', 'checked'=>1, 'enabled'=>1, 'position'=>90, 'csslist'=>'right'); $arrayfields = dol_sort_array($arrayfields, 'position'); -$permissiontoread = $user->rights->recruitment->recruitmentjobposition->read; -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; -$permissiontodelete = $user->rights->recruitment->recruitmentjobposition->delete; +$permissiontoread = $user->hasRight('recruitment', 'recruitmentjobposition', 'read'); +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); +$permissiontodelete = $user->hasRight('recruitment', 'recruitmentjobposition', 'delete'); // Security check - Protection if external user //if ($user->socid > 0) accessforbidden(); diff --git a/htdocs/recruitment/recruitmentjobposition_note.php b/htdocs/recruitment/recruitmentjobposition_note.php index f6e5eec721d..6508ac254f4 100644 --- a/htdocs/recruitment/recruitmentjobposition_note.php +++ b/htdocs/recruitment/recruitmentjobposition_note.php @@ -56,8 +56,8 @@ if ($id > 0 || !empty($ref)) { $upload_dir = $conf->recruitment->multidir_output[!empty($object->entity) ? $object->entity : $conf->entity]."/".$object->id; } -$permissionnote = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_setnotes.inc.php -$permissiontoadd = $user->rights->recruitment->recruitmentjobposition->write; // Used by the include of actions_addupdatedelete.inc.php +$permissionnote = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_setnotes.inc.php +$permissiontoadd = $user->hasRight('recruitment', 'recruitmentjobposition', 'write'); // Used by the include of actions_addupdatedelete.inc.php // Security check - Protection if external user //if ($user->socid > 0) accessforbidden(); diff --git a/htdocs/societe/class/api_contacts.class.php b/htdocs/societe/class/api_contacts.class.php index 9d6ed42ddb1..9aff444a242 100644 --- a/htdocs/societe/class/api_contacts.class.php +++ b/htdocs/societe/class/api_contacts.class.php @@ -380,7 +380,7 @@ class Contacts extends DolibarrApi */ public function createUser($id, $request_data = null) { - //if (!DolibarrApiAccess::$user->rights->user->user->creer) { + //if (!DolibarrApiAccess::$user->hasRight('user', 'user', 'creer')) { //throw new RestException(401); //} @@ -394,7 +394,7 @@ class Contacts extends DolibarrApi if (!DolibarrApiAccess::$user->rights->societe->contact->lire) { throw new RestException(401, 'No permission to read contacts'); } - if (!DolibarrApiAccess::$user->rights->user->user->creer) { + if (!DolibarrApiAccess::$user->hasRight('user', 'user', 'creer')) { throw new RestException(401, 'No permission to create user'); } diff --git a/htdocs/user/bank.php b/htdocs/user/bank.php index 346e693bd56..03c96c45bcf 100644 --- a/htdocs/user/bank.php +++ b/htdocs/user/bank.php @@ -80,7 +80,7 @@ if (empty($account->userid)) { } // Define value to know what current user can do on users -$canadduser = (!empty($user->admin) || $user->rights->user->user->creer || $user->rights->hrm->write_personal_information->write); +$canadduser = (!empty($user->admin) || $user->hasRight('user', 'user', 'creer') || $user->rights->hrm->write_personal_information->write); $canreaduser = (!empty($user->admin) || $user->rights->user->user->lire || $user->rights->hrm->read_personal_information->read); $permissiontoaddbankaccount = (!empty($user->rights->salaries->write) || !empty($user->rights->hrm->employee->write) || $user->hasRight('user', 'creer')); $permissiontoreadhr = $user->hasRight('hrm', 'read_personal_information', 'read') || $user->hasRight('hrm', 'write_personal_information', 'write'); @@ -266,7 +266,7 @@ llxHeader('', $title, $help_url); $head = user_prepare_head($object); -if ($id && $bankid && $action == 'edit' && ($user->rights->user->user->creer || $user->rights->hrm->write_personal_information->write)) { +if ($id && $bankid && $action == 'edit' && ($user->hasRight('user', 'user', 'creer') || $user->rights->hrm->write_personal_information->write)) { if ($conf->use_javascript_ajax) { print "\n