Merge pull request #28734 from mdeweerd/fix/PhanTypeMismatchDimAssignment

Qual: Fix and enable PhanTypeMismatchDimAssignment
This commit is contained in:
Laurent Destailleur 2024-03-12 14:20:34 +01:00 committed by GitHub
commit 367f47428f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions

View file

@ -494,7 +494,7 @@ return [
'PhanRedefineClass',
'PhanRedefineFunction',
'PhanTypeInvalidLeftOperandOfBitwiseOp',
'PhanTypeMismatchDimAssignment',
// 'PhanTypeMismatchDimAssignment',
// 'PhanPluginDescriptionlessCommentOnProtectedMethod',
'PhanPluginPrintfIncompatibleArgumentTypeWeak',
'PhanUndeclaredVariableAssignOp',

View file

@ -2,6 +2,7 @@
/* Copyright (C) 2017 Laurent Destailleur <eldy@users.sourceforge.net>
* Copyright (C) 2017 Regis Houssin <regis.houssin@inodbox.com>
* Copyright (C) 2022 Charlene Benke <charlene@patas-monkey.com>
* Copyright (C) 2024 MDW <mdeweerd@users.noreply.github.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -167,7 +168,10 @@ foreach ($modulesdir as $dir) {
$familyinfo = array_merge($familyinfo, $objMod->familyinfo);
$familykey = key($objMod->familyinfo);
} else {
$familykey = empty($objMod->family) ? 'other' : $objMod->family;
$familykey = $objMod->family;
}
if (empty($familykey) || $familykey === null) {
$familykey = 'other';
}
$moduleposition = ($objMod->module_position ? $objMod->module_position : '50');