From 34e1c81e23fbeeeea016567a68a936ff974987eb Mon Sep 17 00:00:00 2001 From: Zakaria Boushaba <48571684+Boushabazakaria@users.noreply.github.com> Date: Tue, 2 Jun 2026 08:50:14 +0100 Subject: [PATCH] [FIX] Normalize sellist 0 to in actions_addupdatedelete to restore notnull validation on PHP 8.0+ (#38562) Co-authored-by: Zakaria Boushaba --- htdocs/core/actions_addupdatedelete.inc.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/htdocs/core/actions_addupdatedelete.inc.php b/htdocs/core/actions_addupdatedelete.inc.php index 040bd2f8a1c..7b6d0309722 100644 --- a/htdocs/core/actions_addupdatedelete.inc.php +++ b/htdocs/core/actions_addupdatedelete.inc.php @@ -173,6 +173,9 @@ if ($action == 'add' && !empty($permissiontoadd)) { if (!empty($object->fields[$key]['foreignkey']) && $value == '-1') { $value = ''; // This is an explicit foreign key field } + if (preg_match('/^sellist:/i', $object->fields[$key]['type']) && $value == '0') { + $value = ''; // sellist blank option posts "0"; normalize to '' so notnull check works on PHP 8.0+ (see github.com/Dolibarr/dolibarr/issues/38199) + } //var_dump($key.' '.$value.' '.$object->fields[$key]['type'].' '.$object->fields[$key]['notnull']); @@ -335,6 +338,9 @@ if ($action == 'update' && !empty($permissiontoadd)) { if (!empty($object->fields[$key]['foreignkey']) && $value == '-1') { $value = ''; // This is an explicit foreign key field } + if (preg_match('/^sellist:/i', $object->fields[$key]['type']) && $value == '0') { + $value = ''; // sellist blank option posts "0"; normalize to '' so notnull check works on PHP 8.0+ (see github.com/Dolibarr/dolibarr/issues/38199) + } $object->$key = $value;