refactor: clean code

This commit is contained in:
yannis 2025-06-24 11:40:42 +02:00
parent b770bd01b3
commit 336a4c57e0

View file

@ -41,28 +41,25 @@ require_once DOL_DOCUMENT_ROOT.'/core/class/html.formadmin.class.php';
*/
// Load translation files required by page
$langs->loadLangs(array('companies', 'products', 'admin', 'users', 'languages', 'projects', 'members'));
// Defini si peux lire/modifier permissions
$canreaduser = ($user->admin || $user->hasRight("user", "user", "read"));
$caneditfield = false;
$langs->loadLangs(array('admin', 'users'));
// Security check
$id = GETPOSTINT('id');
$action = GETPOST('action', 'aZ09');
$contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'userihm'; // To manage different context of search
$massaction = GETPOST('massaction', 'alpha');
if (!isset($id) || empty($id)) {
accessforbidden();
}
'@phan-var-force int<1,max> $id';
// Retrieve needed GETPOSTS for this file
$toselect = GETPOST('toselect', 'array');
// $user est le user qui edite, $id est l'id de l'utilisateur edite
// $user is current user, $id is id of edited user
$canreaduser = ($user->admin || $user->hasRight("user", "user", "read"));
$caneditfield = ((($user->id == $id) && $user->hasRight("user", "self", "write"))
|| (($user->id != $id) && $user->hasRight("user", "user", "write")));
// Security check
$socid = 0;
if ($user->socid > 0) {
@ -70,9 +67,6 @@ if ($user->socid > 0) {
}
$feature2 = (($socid && $user->hasRight("user", "self", "write")) ? '' : 'user');
// Initialize a technical object to manage hooks of page. Note that conf->hooks_modules contains an array of hook context
$hookmanager->initHooks(array('usercard', 'userihm', 'globalcard'));
$result = restrictedArea($user, 'user', $id, 'user&user', $feature2);
if ($user->id != $id && !$canreaduser) {
accessforbidden();
@ -113,20 +107,12 @@ $help_url = '';
llxHeader('', $title, $help_url, '', 0, 0, '', '', '', 'mod-user page-card_param_ihm');
$massaction = GETPOST('massaction', 'alpha');
$arrayofselected = is_array($toselect) ? $toselect : array();
$head = user_prepare_head($object);
$title = $langs->trans("User");
if ($action == 'edit') {
print '<form method="post" action="'.$_SERVER["PHP_SELF"].'">';
print '<input type="hidden" name="token" value="'.newToken().'">';
print '<input type="hidden" name="action" value="update">';
print '<input type="hidden" name="id" value="'.$id.'">';
}
print dol_get_fiche_head($head, 'apitoken', $title, -1, 'user');
$linkback = '<a href="'.DOL_URL_ROOT.'/user/list.php?restore_lastsearch_values=1">'.$langs->trans("BackToList").'</a>';
@ -140,13 +126,8 @@ $morehtmlref .= dolButtonToOpenUrlInDialogPopup('publicvirtualcard', $langs->tra
dol_banner_tab($object, 'id', $linkback, $user->hasRight("user", "user", "read") || $user->admin, 'rowid', 'ref', $morehtmlref);
$arrayofmassactions['predelete'] = img_picto('', 'delete', 'class="pictofixedwidth"').$langs->trans("Delete");
$massactionbutton = $form->selectMassAction('', $arrayofmassactions);
print '<div class="fichecenter">';
print '<div class="underbanner clearboth"></div>';
print '<table class="border centpercent tableforfield">';
// Login
@ -169,15 +150,16 @@ if (!empty($object->ldap_sid) && $object->status == 0) {
print '</td>';
}
print '</tr>'."\n";
print '</table>';
print '</div>';
print dol_get_fiche_end();
print '<!-- Token section -->'."\n";
$arrayofmassactions['predelete'] = img_picto('', 'delete', 'class="pictofixedwidth"').$langs->trans("Delete");
$massactionbutton = $form->selectMassAction('', $arrayofmassactions);
$morehtmlright = '';
//if (!empty($moreoptions['showhideaddbutton']) && $conf->use_javascript_ajax) {
$tmpurlforbutton = DOL_URL_ROOT.'/user/api_token/list.php?id='.$id.'&action=create';
@ -187,7 +169,6 @@ $morehtmlright .= dolGetButtonTitle($langs->trans('New'), '', 'fa fa-plus-circle
print '<form method="POST" action="'.$_SERVER["PHP_SELF"].'">'."\n";
print '<input type="hidden" name="token" value="'.newToken().'">';
print load_fiche_titre($langs->trans("ListOfTokensForUser"), $morehtmlright, '', 0, '', '', $massactionbutton);
print '</form>';