From 227e13fe313a4e886c2255614f97f2be2e951888 Mon Sep 17 00:00:00 2001 From: Laurent Destailleur Date: Wed, 4 Sep 2024 22:27:18 +0200 Subject: [PATCH] Fix phan --- htdocs/core/modules/project/task/mod_task_simple.php | 6 +++--- htdocs/core/modules/project/task/mod_task_universal.php | 4 ++-- htdocs/core/modules/project/task/modules_task.php | 7 +++++++ 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/htdocs/core/modules/project/task/mod_task_simple.php b/htdocs/core/modules/project/task/mod_task_simple.php index 9dddda43171..71665bb5429 100644 --- a/htdocs/core/modules/project/task/mod_task_simple.php +++ b/htdocs/core/modules/project/task/mod_task_simple.php @@ -100,9 +100,9 @@ class mod_task_simple extends ModeleNumRefTask $posindice = strlen($this->prefix) + 6; $sql = "SELECT MAX(CAST(SUBSTRING(task.ref FROM ".$posindice.") AS SIGNED)) as max"; $sql .= " FROM ".MAIN_DB_PREFIX."projet_task AS task, "; - $sql .= MAIN_DB_PREFIX."projet AS project WHERE task.fk_projet=project.rowid"; + $sql .= MAIN_DB_PREFIX."projet AS project WHERE task.fk_projet = project.rowid"; $sql .= " AND task.ref LIKE '".$db->escape($this->prefix)."____-%'"; - $sql .= " AND project.entity = ".$conf->entity; + $sql .= " AND project.entity = ".((int) $conf->entity); $resql = $db->query($sql); if ($resql) { $row = $db->fetch_row($resql); @@ -130,7 +130,7 @@ class mod_task_simple extends ModeleNumRefTask */ public function getNextValue($objsoc, $object) { - global $db, $conf; + global $db; // First, we get the max value $posindice = strlen($this->prefix) + 6; diff --git a/htdocs/core/modules/project/task/mod_task_universal.php b/htdocs/core/modules/project/task/mod_task_universal.php index 50ce79786fe..6aef36d697b 100644 --- a/htdocs/core/modules/project/task/mod_task_universal.php +++ b/htdocs/core/modules/project/task/mod_task_universal.php @@ -106,7 +106,7 @@ class mod_task_universal extends ModeleNumRefTask */ public function getExample() { - global $conf, $langs, $mysoc; + global $langs, $mysoc; $old_code_client = $mysoc->code_client; $mysoc->code_client = 'CCCCCCCCCC'; @@ -128,7 +128,7 @@ class mod_task_universal extends ModeleNumRefTask */ public function getNextValue($objsoc, $object) { - global $db, $conf; + global $db; require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php'; diff --git a/htdocs/core/modules/project/task/modules_task.php b/htdocs/core/modules/project/task/modules_task.php index ca3fff621a3..29a8947997f 100644 --- a/htdocs/core/modules/project/task/modules_task.php +++ b/htdocs/core/modules/project/task/modules_task.php @@ -84,4 +84,11 @@ abstract class ModeleNumRefTask extends CommonNumRefGenerator * @return string|int<-1,0> Value if OK, <=0 if KO */ abstract public function getNextValue($objsoc, $object); + + /** + * Return an example of numbering + * + * @return string Example + */ + abstract public function getExample(); }