vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix $mybool |=... which is binary op, not boolean op

Browse source 
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
This commit is contained in:
MDW 2024-03-21 13:22:22 +01:00
parent b452a89cc3
commit 15f38d472e
No known key found for this signature in database
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
htdocs/supplier_proposal/class/supplier_proposal.class.php
View file

@ -2429,7 +2429,7 @@ class SupplierProposal extends CommonObject
$dir = dol_buildpath($reldir."core/modules/supplier_proposal/");
// Load file with numbering class (if found)
$mybool |= @include_once $dir.$file;
$mybool = ((bool) @include_once $dir.$file) || $mybool;
}
if (!$mybool) {