From 113716f2a09f38462011447fefb2daeaa30788bc Mon Sep 17 00:00:00 2001 From: rlaurent-alb Date: Fri, 10 Jul 2026 17:53:44 +0200 Subject: [PATCH] FIX: Prevent total discount rounding error on standard lines (#39044) * FIX: Prevent total discount rounding error on standard lines Added a missing check in pdfGetLineTotalDiscountAmount() to skip the discount math entirely on lines without a discount. This prevents subprice rounding discrepancies on standard items from incorrectly altering the document's total discount. * FIX: Resolve rounding discrepancy in PDF line total discount calculation Ensured `pdfGetLineTotalDiscountAmount()` applies `price2num()` rounding to the theoretical line total `(subprice * qty)` *before* subtracting `total_ht`. This identically matches the database insertion logic, preventing false 1-cent rounding discrepancies from bleeding into the total document discount pool. --- htdocs/core/lib/pdf.lib.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/htdocs/core/lib/pdf.lib.php b/htdocs/core/lib/pdf.lib.php index 443e82e6c96..9b9f42a131c 100644 --- a/htdocs/core/lib/pdf.lib.php +++ b/htdocs/core/lib/pdf.lib.php @@ -2917,9 +2917,11 @@ function pdfGetLineTotalDiscountAmount($object, $i, $outputlangs, $hidedetails = if (empty($hidedetails) || $hidedetails > 1) { if (empty($multicurrency)) { - return (float) price2num($sign * (($object->lines[$i]->subprice * (float) $object->lines[$i]->qty) - $object->lines[$i]->total_ht), 'MT', 1); + $diff = (float) price2num($sign * $object->lines[$i]->subprice * (float) $object->lines[$i]->qty, 'MT', 1) - $object->lines[$i]->total_ht; + return (float) price2num($diff, 'MT', 1); } else { - return (float) price2num($sign * (($object->lines[$i]->multicurrency_subprice * (float) $object->lines[$i]->qty) - $object->lines[$i]->multicurrency_total_ht), 'MT', 1); + $diff = (float) price2num($sign * $object->lines[$i]->multicurrency_subprice * (float) $object->lines[$i]->qty, 'MT', 1) - $object->lines[$i]->multicurrency_total_ht; + return (float) price2num($diff, 'MT', 1); } } }