vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix : Warning: Undefined array key "help" in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/admin/dict.php on line 1810 (#29642)

Browse source 
* fix : Warning: Undefined variable  in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/compta/bank/various_payment/list.php on line 370

* backward

* update

* fix : Warning: Undefined array key help in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/admin/dict.php on line 1810

* fix typo in extrafields.class.php
This commit is contained in:
Philippe Grand 2024-05-10 01:25:35 +02:00 committed by GitHub
parent 0cce9ac3c0
commit 0fcbdcb408
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
htdocs/admin/dict.php
View file

@ -1807,7 +1807,7 @@ if ($id > 0) {
}
if (in_array($value, array('label', 'libelle', 'libelle_facture')) && empty($tabcomplete[$tabname[$id]]['help'][$value])) {
if (!is_array($tabcomplete[$tabname[$id]]['help'])) { // protection when $tabcomplete[$tabname[$id]]['help'] is a an empty string, we must force it into an array
if (!isset($tabcomplete[$tabname[$id]]['help']) || !is_array($tabcomplete[$tabname[$id]]['help'])) { // protection when $tabcomplete[$tabname[$id]]['help'] is a an empty string, we must force it into an array
$tabcomplete[$tabname[$id]]['help'] = array();
}
$tabcomplete[$tabname[$id]]['help'][$value] = $langs->trans('LabelUsedByDefault');

2
htdocs/core/class/extrafields.class.php
View file

@ -1589,7 +1589,7 @@ class ExtraFields
} elseif ($type == 'link') {
$param_list = array_keys($param['options']); // $param_list[0] = 'ObjectName:classPath' but can also be 'ObjectName:classPath:1:(status:=:1)'
/* Removed.
The selectForForms is called with parameter $objectfield defined, so the app can retreive the filter inside the ajax component instead of being provided as parameters. The
The selectForForms is called with parameter $objectfield defined, so the app can retrieve the filter inside the ajax component instead of being provided as parameters. The
filter was used to pass SQL requests leading to serious SQL injection problem. This should not be possible. Also the call of the ajax was broken by some WAF.
if (strpos($param_list[0], '$ID$') !== false && !empty($objectid)) {
$param_list[0] = str_replace('$ID$', $objectid, $param_list[0]);