41d4148edb
- Updated goal model to include currency, allowing for multiple currencies in goals. - Modified goal totals calculation to keep currencies separate and accurately reflect targets and achievements. - Added tests to ensure correct handling of multiple currencies in goal tracking. - Enhanced invoice reports to support multiple currencies, ensuring accurate reporting without summing across different currencies. - Implemented lead board provider tests to validate lead movement and pipeline functionality. - Introduced record edit verb tests for accounts, contacts, and leads, ensuring PATCH requests are correctly formed. - Improved tag normalization to handle non-Latin scripts and prevent duplicates.
117 lines
4.1 KiB
Python
117 lines
4.1 KiB
Python
"""Id lists in a task write body: malformed is a 400 and writes nothing.
|
|
|
|
``tags`` went through a raw ``json.loads`` and straight into an id lookup on
|
|
create and PUT, so ``"not-json"`` or ``["nope"]`` answered 500. Every relation
|
|
was also parsed after the task had been saved, so even the 400s arrived with
|
|
the write already done. All of them now parse through ``payload_id_list``
|
|
before the first write.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from common.models import Tags, Teams
|
|
from contacts.models import Contact
|
|
from tasks.models import Task
|
|
|
|
URL = "/api/tasks/"
|
|
CREATE = {"title": "New task", "status": "New", "priority": "High"}
|
|
UPDATE = {"title": "After", "status": "New", "priority": "High"}
|
|
FIELDS = ["contacts", "teams", "assigned_to", "tags"]
|
|
MALFORMED = ["not-json", "[not json", ["nope"], {"a": 1}, [1]]
|
|
|
|
|
|
@pytest.fixture
|
|
def pairs(org_a, org_b, admin_profile, profile_b):
|
|
"""Per field: one object in the caller's org, one in another org."""
|
|
return {
|
|
"contacts": (
|
|
Contact.objects.create(first_name="Ours", last_name="C", org=org_a),
|
|
Contact.objects.create(first_name="Theirs", last_name="C", org=org_b),
|
|
),
|
|
"teams": (
|
|
Teams.objects.create(name="Ours", description="-", org=org_a),
|
|
Teams.objects.create(name="Theirs", description="-", org=org_b),
|
|
),
|
|
"assigned_to": (admin_profile, profile_b),
|
|
"tags": (
|
|
Tags.objects.create(name="Ours", org=org_a),
|
|
Tags.objects.create(name="Theirs", org=org_b),
|
|
),
|
|
}
|
|
|
|
|
|
@pytest.fixture
|
|
def task(org_a, admin_user, pairs):
|
|
"""An existing task already linked to our object in every relation."""
|
|
task = Task.objects.create(
|
|
title="Before",
|
|
status="New",
|
|
priority="High",
|
|
org=org_a,
|
|
created_by=admin_user,
|
|
)
|
|
for field, (ours, _) in pairs.items():
|
|
getattr(task, field).add(ours)
|
|
return task
|
|
|
|
|
|
@pytest.mark.django_db
|
|
class TestTaskBodyIds:
|
|
@pytest.mark.parametrize("value", MALFORMED)
|
|
@pytest.mark.parametrize("field", FIELDS)
|
|
def test_create_malformed_is_400_and_creates_nothing(
|
|
self, admin_client, field, value
|
|
):
|
|
before = Task.objects.count()
|
|
|
|
response = admin_client.post(URL, {**CREATE, field: value}, format="json")
|
|
|
|
assert response.status_code == 400
|
|
assert field in response.data
|
|
assert Task.objects.count() == before
|
|
|
|
@pytest.mark.parametrize("value", MALFORMED)
|
|
@pytest.mark.parametrize("field", FIELDS)
|
|
@pytest.mark.parametrize("method", ["put", "patch"])
|
|
def test_update_malformed_is_400_and_changes_nothing(
|
|
self, admin_client, task, pairs, method, field, value
|
|
):
|
|
response = getattr(admin_client, method)(
|
|
f"{URL}{task.id}/", {**UPDATE, field: value}, format="json"
|
|
)
|
|
|
|
assert response.status_code == 400
|
|
assert field in response.data
|
|
task.refresh_from_db()
|
|
assert task.title == "Before"
|
|
for name, (ours, _) in pairs.items():
|
|
assert list(getattr(task, name).all()) == [ours], name
|
|
|
|
@pytest.mark.parametrize("field", FIELDS)
|
|
def test_create_attaches_only_the_callers_org(self, admin_client, pairs, field):
|
|
ours, theirs = pairs[field]
|
|
|
|
response = admin_client.post(
|
|
URL, {**CREATE, field: [str(ours.id), str(theirs.id)]}, format="json"
|
|
)
|
|
|
|
assert response.status_code == 200, response.data
|
|
created = Task.objects.get(title=CREATE["title"])
|
|
assert list(getattr(created, field).all()) == [ours]
|
|
|
|
@pytest.mark.parametrize("field", FIELDS)
|
|
@pytest.mark.parametrize("method", ["put", "patch"])
|
|
def test_update_attaches_only_the_callers_org(
|
|
self, admin_client, task, pairs, method, field
|
|
):
|
|
ours, theirs = pairs[field]
|
|
getattr(task, field).clear()
|
|
|
|
response = getattr(admin_client, method)(
|
|
f"{URL}{task.id}/",
|
|
{**UPDATE, field: [str(ours.id), str(theirs.id)]},
|
|
format="json",
|
|
)
|
|
|
|
assert response.status_code == 200, response.data
|
|
assert list(getattr(task, field).all()) == [ours]
|