bottleneckcrm/backend/leads/access.py
Ashwin 66421bbad0 Add ticket approval panel tests and enhance ticket board functionality
- Implement tests for ticket approval panel to verify approval request logic and visibility based on user roles.
- Add functionality to handle ticket movement based on server response for both tickets and leads.
- Introduce new tests for duplicate checking API to ensure correct handling of duplicates and merging logic.
- Remove outdated permissions tests that are no longer relevant.
- Update ticket board and lead board providers to include 'can_move' field for better control over ticket actions.
- Refactor existing tests to improve coverage and ensure accurate representation of API responses.
2026-09-26 23:33:20 +05:30

59 lines
2.3 KiB
Python

"""Who may see a lead.
One rule, asked two ways: ``visible_leads_qs`` narrows a queryset (the lead list,
the board, the pipeline lead counts, and the detail, move, comment and
attachment lookups, so a hidden lead is the same 404 as a missing one), and
``has_lead_access`` answers for one lead (the attachment download). Both live
here so the answers cannot drift apart.
"""
from django.db.models import Q
from common.permissions import is_org_admin
from leads.models import Lead
def has_lead_access(profile, lead):
"""Org admins (``is_org_admin``, which admits a superuser's profile) see
every lead in the org; everyone else sees their own.
The same rule as ``visible_leads_qs``, for one lead. Without it, a lead the
list deliberately withholds is still readable by id.
``Lead.created_by`` is a **User** FK, so the creator half compares
``profile.user_id``. Two hand-rolled copies of this check once built a set
of Profile ids and appended a User id to it, which meant the creator's own
id was never in the set and the check denied the person it existed to
admit.
"""
if is_org_admin(profile):
return True
if profile.user_id == lead.created_by_id:
return True
return profile.id in {assignee.id for assignee in lead.assigned_to.all()}
def may_delete_lead(profile, lead):
"""Narrower than reading or editing: admins (superusers included) and the
lead's creator. An assignee may open and edit a lead but not destroy it,
which includes merging it away into another lead."""
return is_org_admin(profile) or profile.user_id == lead.created_by_id
def visible_leads_qs(profile):
"""Leads ``profile`` may open, the queryset form of `has_lead_access`.
The lead list, the board and the pipeline ``lead_count`` all start from
this. Status and ``is_active`` are left to each caller.
The assignee half is a subquery rather than a join on the M2M, so a lead
with several assignees comes back once without ``distinct()``, and the
queryset can sit inside a filtered ``Count`` annotation as it is.
"""
qs = Lead.objects.filter(org=profile.org)
if is_org_admin(profile):
return qs
return qs.filter(
Q(created_by=profile.user)
| Q(pk__in=Lead.objects.filter(assigned_to=profile).values("pk"))
)